Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOSIP-38627] Updated vs and values.yaml . #196

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

abhishek8shankar
Copy link
Member

No description provided.

{{- else if eq .matchType "prefix" }}
prefix: {{ .uri }}
{{- end }}
{{- if eq .matchType "exact" }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhishek8shankar you have the same condition above aswell can we make the rewrite.uri also a part of the same instead of having the same condition again.

{{- end }}
labels:
{{- include "common.labels.standard" . | nindent 4 }}
{{- if .Values.commonLabels }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhishek8shankar can you please check the indentation here.

uriMatches:
- matchType: prefix
uri: /
port: 80

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the port is same for both prefix and exact matchtype can we exclude it from here and specify outside this block and if port is different then please add port in exact matchtype aswell.

Copy link

@Mohanraj209 Mohanraj209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes as mentioned. @abhishek8shankar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants