-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOSIP-38627] Updated vs and values.yaml . #196
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Abhishek S <[email protected]>
Signed-off-by: Abhishek S <[email protected]>
{{- else if eq .matchType "prefix" }} | ||
prefix: {{ .uri }} | ||
{{- end }} | ||
{{- if eq .matchType "exact" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhishek8shankar you have the same condition above aswell can we make the rewrite.uri also a part of the same instead of having the same condition again.
{{- end }} | ||
labels: | ||
{{- include "common.labels.standard" . | nindent 4 }} | ||
{{- if .Values.commonLabels }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhishek8shankar can you please check the indentation here.
uriMatches: | ||
- matchType: prefix | ||
uri: / | ||
port: 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the port is same for both prefix and exact matchtype can we exclude it from here and specify outside this block and if port is different then please add port in exact matchtype aswell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the requested changes as mentioned. @abhishek8shankar
No description provided.