Critical code review PR - Last sprint handover checklist of 0.10.0 release #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier `/issuance/.well-known/openid-credential-issuer?version=v123` would return the latest versioned issuer metadata earlier if it was not valid, now returns an error. Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Challa Rao <[email protected]>
[DSD-5526] Update init_db.sh namespace and chart version
Signed-off-by: Harsh Vardhan <[email protected]>
[INJICERT-236] throw error when unsupported wellknown version requested
Signed-off-by: Challarao <[email protected]>
[INJICERT-37] rename certify database name
Signed-off-by: VSIVAKALYAN <[email protected]>
[DSD-5618] Update init_values.yaml
* [INJICERT-248] use well known config from spring from separate JSON file Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] fixup JSON formatting of well-known config Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] Fixup formatting & resource URL Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] add missing config for mock-identity Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] parse metadata when mediatype is text/plain Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-248] rename openid4vci well known file Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: ckm007 <[email protected]>
[MOSIP-34749] removed platform related DB's reference
Signed-off-by: Praful Rakhade <[email protected]>
[DSD-5853] updated Dockerfile
Signed-off-by: Nandhukumar <[email protected]>
#49)" (#59) This reverts commit c1c4e43. Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Rakshitha650 <[email protected]>
Signed-off-by: Rakshitha650 <[email protected]>
[MOSIP-34818]Updated values.yaml
Signed-off-by: Nandhukumar <[email protected]>
Signed-off-by: Nandhukumar <[email protected]>
Signed-off-by: Nandhukumar <[email protected]>
Signed-off-by: Nandhukumar <[email protected]>
Signed-off-by: Nandhukumar <[email protected]>
Signed-off-by: Nandhukumar <[email protected]>
Signed-off-by: Nandhukumar <[email protected]>
MOSIP-33742 | Created component based API test rig for Inji-certify
Signed-off-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>
* [INJICERT-695] add mock mdoc VCI postman collection Signed-off-by: KiruthikaJeyashankar <[email protected]> * [INJICERT-695] modify property name of mdoc issuer key certificate mosip.certify.mock.vciplugin.issuer.key-cert changed to mosip.certify.mock.vciplugin.mdoc.issuer-key-cert Signed-off-by: KiruthikaJeyashankar <[email protected]> --------- Signed-off-by: KiruthikaJeyashankar <[email protected]> Signed-off-by: Vishwa <[email protected]>
* [INJICERT-657] Added some deployment changes Signed-off-by: Piyush7034 <[email protected]> * [INJICERT-657] Change in extraEnvVars yaml value Signed-off-by: Piyush7034 <[email protected]> --------- Signed-off-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>
Signed-off-by: Piyush7034 <[email protected]> Signed-off-by: Vishwa <[email protected]>
This reverts commit 443262e. Signed-off-by: Vishwa <[email protected]>
Signed-off-by: Harsh <[email protected]> Signed-off-by: Vishwa <[email protected]>
Signed-off-by: KiruthikaJeyashankar <[email protected]> Signed-off-by: Vishwa <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Vishwa <[email protected]>
…ified the docker compose file (#166) Signed-off-by: Vishwa <[email protected]>
Signed-off-by: Harsh <[email protected]>
…plate and docker compose pointed to collab (#168) Signed-off-by: Vishwa <[email protected]> Signed-off-by: Hitesh Jain <[email protected]> Co-authored-by: Hitesh Jain <[email protected]>
* [INJICERT-642] add dev & integrator docs Topics: * add plugin docs * add local development & setup guide * add docs for hosting a DID document Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-642] reorganize docs Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-642] update UINs to match collab setup data Signed-off-by: Harsh <[email protected]> * [INJICERT-642] update farmer logo and readme Signed-off-by: Harsh <[email protected]> * [INJICERT-642] remove redundant docs Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-642] update mDoc docs Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-642] remove mDoc secret generation script Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Harsh <[email protected]> Signed-off-by: Vishwa <[email protected]>
Signed-off-by: Piyush7034 <[email protected]>
…ervice (#165) * [INJICERT-331] Added unit tests for validators and certify issuance service Signed-off-by: Piyush7034 <[email protected]> * Added proof generator and issuance services test cases Signed-off-by: Piyush7034 <[email protected]> * Added few more test for filter and services Signed-off-by: Piyush7034 <[email protected]> --------- Signed-off-by: Piyush7034 <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
* [INJICERT-657] update docs and issuer name Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] update mock mdl configurations Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh <[email protected]>
* [INJICERT-657] use keymanager 1.3.0-SNAPSHOT for release Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] add ca_cert_store table for keymanager Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]>
* [INJICERT-657] update the SQL scripts and troubleshooting guide Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] add sample UIN and OTP for local docker compose setup Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] add keymanager policies to rollback script Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] remove key_policy_defs from 0.9.1 version of Certify Signed-off-by: Harsh Vardhan <[email protected]> * [INJICERT-657] add license header for upgrade & rollback scripts Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]>
…commons release changes (#185) * MOSIP-39143 Signed-off-by: Nandhukumar <[email protected]> * MOSIP-39143 Signed-off-by: Nandhukumar <[email protected]> * MOSIP-39143 Signed-off-by: Nandhukumar <[email protected]> --------- Signed-off-by: Nandhukumar <[email protected]>
Signed-off-by: Hitesh Jain <[email protected]> Signed-off-by: Vishwa <[email protected]>
Signed-off-by: Abhishek S <[email protected]>
Signed-off-by: Abhishek S <[email protected]>
[MOSIP-39240] Updated install.sh and values.yaml to use config-server
Signed-off-by: Mohanachandran S <[email protected]>
* Openapi review comments Signed-off-by: Hitesh Jain <[email protected]> * [Release Changes] Updated openapi docs Signed-off-by: Hitesh Jain <[email protected]> * [release changes] updated openapi docs Signed-off-by: Hitesh Jain <[email protected]> * [Swagger changes] added additional examples Signed-off-by: Hitesh Jain <[email protected]> * [Openapi changes] updated scope Signed-off-by: Hitesh Jain <[email protected]> * [Updated README] added rendering template workflow in readme Signed-off-by: Hitesh Jain <[email protected]> * [Restructured readme] Signed-off-by: Hitesh Jain <[email protected]> * [cleanup] Signed-off-by: Hitesh Jain <[email protected]> * [removed unnecessary headers] Signed-off-by: Hitesh Jain <[email protected]> * removed unnecessary content Signed-off-by: Hitesh Jain <[email protected]> --------- Signed-off-by: Hitesh Jain <[email protected]> Signed-off-by: Vishwa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created just to add the review comments as part of the critical code review task of last sprint handover checklist for release of 0.10.0 version.
** THIS PR SHOULD NOT BE MERGED **