DSD-4457 #72
Merged
DSD-4457 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mengleang-ngoun <[email protected]>
Signed-off-by: mengleang-ngoun <[email protected]>
Signed-off-by: mengleang-ngoun <[email protected]>
Signed-off-by: mengleang-ngoun <[email protected]>
ase-101
approved these changes
Feb 16, 2024
Prafulrakhade
pushed a commit
that referenced
this pull request
Feb 29, 2024
* create service controller dto for reset password endpoint * complete multi auth challenge verify * fix unit test * fix unit test * fix unit test * complate unit test * multi-auth challenge verify * fix styling * rename addIdentity res and req DTO to Identity * add switch case in postVerifiedChallenge * create constant for acticated indentity * create controller and service * move reset-password endpoint to SignUpController * resolve conflict with develop commit d136cb4 * Revert "resolve conflict with develop commit d136cb4" This reverts commit 8f482a66292f2bc2e4637280936fa27c33d6d1f6. * resolve test case error after resolve conflict * fix cannot reset password * fix json convert in identity * add unit test on reset password * update route path * add more test case in resetPassword controller * rewrite challenge validator and add handler from id repo service * add end line in lombok.config * resolve config and add more ErrorConstants * remove ignore test case * remove used ErrorConstants * add otp size * update cors and csrf * add test case and add transaction to registered * add sms notification template * send sms notification when successfully reset password * remove check Challenge OTP length * update test case name --------- Co-authored-by: Mengleang <[email protected]> Signed-off-by: Sreang Rathanak <[email protected]>
mengleang-0090
added a commit
to mengleang-0090/public-esignet-signup
that referenced
this pull request
Mar 15, 2024
* fix cookie without secure code Signed-off-by: mengleang-ngoun <[email protected]> * fix code bug Signed-off-by: mengleang-ngoun <[email protected]> * update sonar ignore on getChache Signed-off-by: mengleang-ngoun <[email protected]> * fix null on message Signed-off-by: mengleang-ngoun <[email protected]> --------- Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Mengleang <[email protected]>
mengleang-0090
added a commit
to mengleang-0090/public-esignet-signup
that referenced
this pull request
Mar 15, 2024
* fix cookie without secure code Signed-off-by: mengleang-ngoun <[email protected]> * fix code bug Signed-off-by: mengleang-ngoun <[email protected]> * update sonar ignore on getChache Signed-off-by: mengleang-ngoun <[email protected]> * fix null on message Signed-off-by: mengleang-ngoun <[email protected]> --------- Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Mengleang <[email protected]> Signed-off-by: mengleang-0090 <[email protected]>
mengleang-0090
added a commit
to mengleang-0090/public-esignet-signup
that referenced
this pull request
Mar 15, 2024
* fix cookie without secure code Signed-off-by: mengleang-ngoun <[email protected]> * fix code bug Signed-off-by: mengleang-ngoun <[email protected]> * update sonar ignore on getChache Signed-off-by: mengleang-ngoun <[email protected]> * fix null on message Signed-off-by: mengleang-ngoun <[email protected]> --------- Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Mengleang <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: mengleang-0090 <[email protected]>
mengleang-0090
added a commit
to mengleang-0090/public-esignet-signup
that referenced
this pull request
Mar 27, 2024
* fix cookie without secure code Signed-off-by: mengleang-ngoun <[email protected]> * fix code bug Signed-off-by: mengleang-ngoun <[email protected]> * update sonar ignore on getChache Signed-off-by: mengleang-ngoun <[email protected]> * fix null on message Signed-off-by: mengleang-ngoun <[email protected]> --------- Signed-off-by: mengleang-ngoun <[email protected]>
mengleang-0090
added a commit
to mengleang-0090/public-esignet-signup
that referenced
this pull request
Mar 27, 2024
* fix cookie without secure code Signed-off-by: mengleang-ngoun <[email protected]> * fix code bug Signed-off-by: mengleang-ngoun <[email protected]> * update sonar ignore on getChache Signed-off-by: mengleang-ngoun <[email protected]> * fix null on message Signed-off-by: mengleang-ngoun <[email protected]> --------- Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Mengleang <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: mengleang-0090 <[email protected]>
mengleang-0090
added a commit
to mengleang-0090/public-esignet-signup
that referenced
this pull request
Mar 27, 2024
* fix cookie without secure code Signed-off-by: mengleang-ngoun <[email protected]> * fix code bug Signed-off-by: mengleang-ngoun <[email protected]> * update sonar ignore on getChache Signed-off-by: mengleang-ngoun <[email protected]> * fix null on message Signed-off-by: mengleang-ngoun <[email protected]> --------- Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: mengleang-0090 <[email protected]>
balaji-alluru
pushed a commit
to balaji-alluru/esignet-signup
that referenced
this pull request
Apr 30, 2024
* fix cookie without secure code Signed-off-by: mengleang-ngoun <[email protected]> * fix code bug Signed-off-by: mengleang-ngoun <[email protected]> * update sonar ignore on getChache Signed-off-by: mengleang-ngoun <[email protected]> * fix null on message Signed-off-by: mengleang-ngoun <[email protected]> --------- Signed-off-by: mengleang-ngoun <[email protected]>
balaji-alluru
pushed a commit
to balaji-alluru/esignet-signup
that referenced
this pull request
Apr 30, 2024
* fix cookie without secure code Signed-off-by: mengleang-ngoun <[email protected]> * fix code bug Signed-off-by: mengleang-ngoun <[email protected]> * update sonar ignore on getChache Signed-off-by: mengleang-ngoun <[email protected]> * fix null on message Signed-off-by: mengleang-ngoun <[email protected]> --------- Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Balaji <[email protected]>
ase-101
added a commit
that referenced
this pull request
May 3, 2024
* ES-782 (#70) Signed-off-by: pr <[email protected]> Signed-off-by: Balaji <[email protected]> * DSD-4457 (#72) * fix cookie without secure code Signed-off-by: mengleang-ngoun <[email protected]> * fix code bug Signed-off-by: mengleang-ngoun <[email protected]> * update sonar ignore on getChache Signed-off-by: mengleang-ngoun <[email protected]> * fix null on message Signed-off-by: mengleang-ngoun <[email protected]> --------- Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Balaji <[email protected]> * ES 802 (#76) * Signup service - Changes required in Async notification calls Signed-off-by: mengleang-ngoun <[email protected]> * throw exception and add test case Signed-off-by: mengleang-ngoun <[email protected]> --------- Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Balaji <[email protected]> * ES-973 (#77) Signed-off-by: pr <[email protected]> Signed-off-by: Balaji <[email protected]> * Error message when multiple user attempting to register with same identifier simultaneously should be changed to user friendly message. Signed-off-by: Sreang Rathanak <[email protected]> Signed-off-by: Balaji <[email protected]> * ES-789 (#79) * add local in request header Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Mengleang <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> * update wording Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Mengleang <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> * resolve conflict Signed-off-by: mengleang-0090 <[email protected]> * update test case Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Mengleang <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> * move locale into registration request Signed-off-by: Mengleang <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> * front end move locale into request body Signed-off-by: Mengleang <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> * Issues with cached methods found during redis integration fixed (#68) Signed-off-by: ase-101 <[email protected]> * move locale to req body in Reset password endpoint Signed-off-by: mengleang-0090 <[email protected]> * handle locale registerRequest and resetPasswordRequest null Signed-off-by: mengleang-0090 <[email protected]> * convert 2 to 3 langCode Signed-off-by: mengleang-0090 <[email protected]> * remove locale from header Signed-off-by: mengleang-0090 <[email protected]> --------- Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Mengleang <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: ase-101 <[email protected]> Co-authored-by: Mengleang <[email protected]> Co-authored-by: ase-101 <[email protected]> Signed-off-by: Balaji <[email protected]> * Error message when identifier blocked in the UI can be revised Signed-off-by: Sreang Rathanak <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-831] [ES-833] Fixed: Error messages are not getting disappeared for below scenarios. Fixed: Otp text boxes are not aligned properly when Otp length is increased 8 Signed-off-by: GurukiranP <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-791] Fixed: User preferred/selected language is not retained during redirection. Signed-off-by: GurukiranP <[email protected]> Signed-off-by: Balaji <[email protected]> * Error message when Username preceded with 0 is not as per story requirements. Signed-off-by: Sreang Rathanak <[email protected]> Signed-off-by: Balaji <[email protected]> * fix: fix breaking words Signed-off-by: Bunsy <[email protected]> Signed-off-by: Balaji <[email protected]> * fix: fix retry button not working Signed-off-by: Bunsy <[email protected]> Signed-off-by: Balaji <[email protected]> * fix: reload fully on some devices only Signed-off-by: bunsy-0900 <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-833] Fixed: Otp text box alignment issue on reset password page. Signed-off-by: GurukiranP <[email protected]> Signed-off-by: Balaji <[email protected]> * Move the language related files to artifactory for signup UI Signed-off-by: Sreang Rathanak <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-863] Signed-off-by: Venkata Saidurga Polamraju <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-855, ES-856] Updated stoplight API documentation (#96) Signed-off-by: Balaji Alluru <[email protected]> Signed-off-by: Balaji <[email protected]> * Fix signup UI build fail (#98) * Fix fail build Signed-off-by: Sreang Rathanak <[email protected]> * Fix fail build Signed-off-by: Sreang Rathanak <[email protected]> --------- Signed-off-by: Sreang Rathanak <[email protected]> Co-authored-by: Sreang Rathanak <[email protected]> Signed-off-by: Balaji <[email protected]> * ES-839: fix color Signed-off-by: pr <[email protected]> Signed-off-by: Balaji <[email protected]> * fix: change favicon Signed-off-by: Bunsy <[email protected]> Signed-off-by: Balaji <[email protected]> * fix: change lang flow Signed-off-by: Bunsy <[email protected]> Signed-off-by: Balaji <[email protected]> * ES-741: disable tooltips in sign up form Signed-off-by: pr <[email protected]> Signed-off-by: Balaji <[email protected]> * ES-741: disable tooltips in sign-up and reset-password forms Signed-off-by: pr <[email protected]> Signed-off-by: Balaji <[email protected]> * improve test coverage (#108) Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: ase-101 <[email protected]> Co-authored-by: ase-101 <[email protected]> Signed-off-by: Balaji <[email protected]> * ES-793 scenario 2 (#110) Signed-off-by: pr <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-851] [ES-831] Allowing the user to re-enter the captcha when resend otp is clicked if mosip.signup.send-challenge.captcha-required is enabled true. Clearing the error messages in some scenarios Signed-off-by: GurukiranP <[email protected]> Signed-off-by: Balaji <[email protected]> * ES-857 (#113) * ES-886 Signed-off-by: pr <[email protected]> * ES-890 Signed-off-by: pr <[email protected]> * ES-887 Signed-off-by: pr <[email protected]> * ES-884 Signed-off-by: pr <[email protected]> * ES-888 Signed-off-by: pr <[email protected]> * ES-885 Signed-off-by: pr <[email protected]> * ES-892 Signed-off-by: pr <[email protected]> * resolve comment Signed-off-by: pr <[email protected]> --------- Signed-off-by: pr <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-832] Fixed: Mobile- Number keypad should be rendered when user navigates to Otp screen. Signed-off-by: GurukiranP <[email protected]> Signed-off-by: Balaji <[email protected]> * Move theme based file to artifactory-ref-impl repo for esignet-signup-ui Signed-off-by: Sreang Rathanak <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-832] Removed secret attribute from otp pin input. Signed-off-by: GurukiranP <[email protected]> Signed-off-by: Balaji <[email protected]> * [ADDED] id & name in signup page component Signed-off-by: Zeeshan Mehboob <[email protected]> Signed-off-by: Balaji <[email protected]> * [ADDED] id & name in landing page component Signed-off-by: Zeeshan Mehboob <[email protected]> Signed-off-by: Balaji <[email protected]> * [ADDED] id & name in reset pwd page component Signed-off-by: Zeeshan Mehboob <[email protected]> Signed-off-by: Balaji <[email protected]> * [ADDED] id & name in common & icons component Signed-off-by: Zeeshan Mehboob <[email protected]> Signed-off-by: Balaji <[email protected]> * ES-785 (#121) Signed-off-by: Sreang Rathanak <[email protected]> Co-authored-by: Sreang Rathanak <[email protected]> Signed-off-by: Balaji <[email protected]> * ES-1069 Signed-off-by: pr <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-831]: Fixed the issue where the error message in still retaining in signup flow. Signed-off-by: GurukiranP <[email protected]> Signed-off-by: Balaji <[email protected]> * [ADDED] copy paste in input field Signed-off-by: Zeeshan Mehboob <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-833]: Fixed the issue for iPhone15+ where Otp text boxes are not aligned properly when Otp length is increased 8. Signed-off-by: GurukiranP <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-833]: Fixed the issue for iPhone15+ where Otp text boxes are not aligned properly when Otp length is increased 8. Signed-off-by: GurukiranP <[email protected]> Signed-off-by: Balaji <[email protected]> * [ES-856]Update esignet-signup-openapi.yaml Signed-off-by: Balaji Alluru <[email protected]> * Update esignet-signup-openapi.yaml Signed-off-by: Balaji Alluru <[email protected]> * [MOSIP-31575] Updated docker file. (#118) * [MOSIP-31575] Updated docker file. Signed-off-by: abhishek8shankar <[email protected]> * [MOSIP-31575] Updated docker file. Signed-off-by: abhishek8shankar <[email protected]> * [MOSIP-31575] Updated docker file. Signed-off-by: abhishek8shankar <[email protected]> * Update push-trigger.yml Signed-off-by: abhishek8shankar <[email protected]> * [MOSIP-31575] Updated docker file. Signed-off-by: abhishek8shankar <[email protected]> * Update push-trigger.yml Signed-off-by: abhishek8shankar <[email protected]> * Update push-trigger.yml Signed-off-by: abhishek8shankar <[email protected]> --------- Signed-off-by: abhishek8shankar <[email protected]> * Updated release pom versions Signed-off-by: Balaji <[email protected]> * [ES-1125] Updated pom file Signed-off-by: Balaji <[email protected]> --------- Signed-off-by: pr <[email protected]> Signed-off-by: Balaji <[email protected]> Signed-off-by: mengleang-ngoun <[email protected]> Signed-off-by: Sreang Rathanak <[email protected]> Signed-off-by: Mengleang <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: mengleang-0090 <[email protected]> Signed-off-by: ase-101 <[email protected]> Signed-off-by: GurukiranP <[email protected]> Signed-off-by: Bunsy <[email protected]> Signed-off-by: bunsy-0900 <[email protected]> Signed-off-by: Venkata Saidurga Polamraju <[email protected]> Signed-off-by: Balaji Alluru <[email protected]> Signed-off-by: Zeeshan Mehboob <[email protected]> Signed-off-by: abhishek8shankar <[email protected]> Co-authored-by: panharith-0118 <[email protected]> Co-authored-by: mengleang-0090 <[email protected]> Co-authored-by: Sreang Rathanak <[email protected]> Co-authored-by: Mengleang <[email protected]> Co-authored-by: ase-101 <[email protected]> Co-authored-by: GurukiranP <[email protected]> Co-authored-by: Bunsy <[email protected]> Co-authored-by: bunsy-0900 <[email protected]> Co-authored-by: Venkata Saidurga Polamraju <[email protected]> Co-authored-by: rathanak-0080 <[email protected]> Co-authored-by: pr <[email protected]> Co-authored-by: Zeeshan Mehboob <[email protected]> Co-authored-by: abhishek8shankar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.