Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-723 #36

Merged
merged 3 commits into from
Jan 29, 2024
Merged

ES-723 #36

merged 3 commits into from
Jan 29, 2024

Conversation

bunsy-0900
Copy link
Contributor

@bunsy-0900 bunsy-0900 commented Jan 29, 2024 •
edited
Loading

Solution

  • subtract otp attempts on successful request only
  • convert otp blocked to minutes
  • show retry after countdown is zero

@bunsy-0900 bunsy-0900 marked this pull request as ready for review January 29, 2024 02:17
@ase-101 ase-101 merged commit 6da2669 into mosip:develop Jan 29, 2024
4 of 5 checks passed
mengleang-0090 added a commit to mengleang-0090/public-esignet-signup that referenced this pull request Feb 12, 2024
@mengleang-0090 @mengleang-ngoun
ES-515 (mosip#36)
5c12ab6 
* change successfull registration sms content

* send sms success notification to user

* change SMS notification helper class for sendSMSNotificationAsync

* update SMS helper name and rename properties key for SMS message template

---------

Co-authored-by: Mengleang <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RathanakSreang RathanakSreang RathanakSreang approved these changes

@aranaravi aranaravi aranaravi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bunsy-0900 @aranaravi @RathanakSreang @ase-101 @bunsyy