ES-628 #32
Merged
ES-628 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ase-101 <[email protected]>
| } catch (Exception e) { | ||
| log.error("Error getting secret key", e); | ||
| KeyGenerator keyGenerator = KeyGenerator.getInstance("AES"); | ||
| keyGenerator.init(256); |
There was a problem hiding this comment.
please move the key size and algorithm name to configurations.
Signed-off-by: ase-101 <[email protected]>
mahammedtaheer
approved these changes
Jan 25, 2024
pvsaidurga
pushed a commit
to pvsaidurga/esignet-signup
that referenced
this pull request
Jan 28, 2024
* add send notification endpoint * send sms otp with async * ASYNC send OTP notification by SMS * add endline in some file * change sms content * change to unicode * encode UTF-8 * rollback to old message content * change message content to utf-8 * change proprieties name * recover test.properties file --------- Co-authored-by: Mengleang <[email protected]> Signed-off-by: Sreang Rathanak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.