ES-659/ES-661: fix truncated icons and popover content #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bunsy-0900 <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
aranaravi
requested changes
Jan 17, 2024
Signed-off-by: bunsy-0900 <[email protected]>
RathanakSreang
approved these changes
Jan 18, 2024
aranaravi
reviewed
Jan 18, 2024
Signed-off-by: bunsy-0900 <[email protected]>
aranaravi
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Mobile: info icon symbol and texts with icon are getting truncated for "Full Name in Khmer" and for "Password" text field in Setup Account screen
Mobile(iphone-7) : info icon is getting disappeared on re-opening the screen from recent apps in account set up screen
Solution
Popup Truncated
Conditionally render the popup based on the screen size of the device.
Info Icon
Since the current svg info icon from Adobe XD has issue in safari of iOS 15, I use the png instead.