-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 8.0, Avalonia 11.0.9 and fix launcher issue #1189
Conversation
AnErrupTion
commented
Feb 16, 2024
- Update to .NET 8.0
- Update to Avalonia 11.0.9
- Don't load MosaSettings again in BaseLauncher.cs and MosaCompiler.cs as they're already initialized by the caller; and make sure they're actually initialized everywhere (e.g. in UnitTestSystem.cs)
- Delete unused backup C# project files
Signed-off-by: AnErrupTion <[email protected]>
Signed-off-by: AnErrupTion <[email protected]>
Signed-off-by: AnErrupTion <[email protected]>
…tings in MosaCompiler.cs Signed-off-by: AnErrupTion <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing some changes, the Directory.Build.props file needs to be updated as well as korlib
The props file is already updated, maybe you didn't see it? Also, Korlib doesn't need to be updated (just like the other BareMetal projects) because it uses the Mosa.BareMetal.targets file, which should itself use the target framework set in Directory.Build.props. |
Sorry, don't know how I missed that the Directory.Build.props file was already updated. In regards to korlib, I believe this line has to be updated to match the dotnet version
|
Signed-off-by: AnErrupTion <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh yeah I forgot about the assembly version! It's not technically required to update it, but it makes things more consistent. Thanks! It's updated now :D |