Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 8.0, Avalonia 11.0.9 and fix launcher issue #1189

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

AnErrupTion
Copy link
Member

  • Update to .NET 8.0
  • Update to Avalonia 11.0.9
  • Don't load MosaSettings again in BaseLauncher.cs and MosaCompiler.cs as they're already initialized by the caller; and make sure they're actually initialized everywhere (e.g. in UnitTestSystem.cs)
  • Delete unused backup C# project files

@AnErrupTion AnErrupTion self-assigned this Feb 16, 2024
Copy link
Member

@charsleysa charsleysa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some changes, the Directory.Build.props file needs to be updated as well as korlib

@AnErrupTion
Copy link
Member Author

Missing some changes, the Directory.Build.props file needs to be updated as well as korlib

The props file is already updated, maybe you didn't see it? Also, Korlib doesn't need to be updated (just like the other BareMetal projects) because it uses the Mosa.BareMetal.targets file, which should itself use the target framework set in Directory.Build.props.

@charsleysa
Copy link
Member

Sorry, don't know how I missed that the Directory.Build.props file was already updated.

In regards to korlib, I believe this line has to be updated to match the dotnet version

<AssemblyVersion>7.0.0.0</AssemblyVersion>

Copy link
Member

@charsleysa charsleysa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnErrupTion
Copy link
Member Author

In regards to korlib, I believe this line has to be updated to match the dotnet version

Oh yeah I forgot about the assembly version! It's not technically required to update it, but it makes things more consistent. Thanks! It's updated now :D

@AnErrupTion AnErrupTion merged commit 4c7dc5f into mosa:master Feb 19, 2024
66 checks passed
@AnErrupTion AnErrupTion deleted the net8.0 branch March 9, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants