Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release process tweaks #3147

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Release process tweaks #3147

merged 2 commits into from
Jan 24, 2025

Conversation

stiiifff
Copy link
Contributor

Release process tweaks (+ typo)

@stiiifff stiiifff requested review from a team as code owners January 21, 2025 12:30
@stiiifff stiiifff added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2272 KB (no changes) ✅

Moonbeam runtime: 2252 KB (no changes) ✅

Moonriver runtime: 2244 KB (no changes) ✅

Compared to latest release (runtime-3401)

Moonbase runtime: 2272 KB (+240 KB compared to latest release) ⚠️

Moonbeam runtime: 2252 KB (+240 KB compared to latest release) ⚠️

Moonriver runtime: 2244 KB (+232 KB compared to latest release) ⚠️

@stiiifff stiiifff added D2-notlive PR doesn't change runtime code (so can't be audited) and removed D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Coverage Report

@@                  Coverage Diff                  @@
##           master   sde/release-tweaks     +/-   ##
=====================================================
  Coverage   74.58%               74.58%   0.00%     
  Files         377                  377             
  Lines       96042                96042             
=====================================================
  Hits        71632                71632             
  Misses      24410                24410
Files Changed Coverage

Coverage generated Wed Jan 22 14:49:17 UTC 2025

RomarQ
RomarQ previously approved these changes Jan 21, 2025
View reviewed changes
pLabarta
pLabarta previously approved these changes Jan 21, 2025
View reviewed changes
@RomarQ RomarQ dismissed stale reviews from pLabarta and themself via 9088dd7 January 22, 2025 14:15
timbrinded
timbrinded approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@timbrinded timbrinded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stiiifff stiiifff merged commit 4e5478d into master Jan 24, 2025
38 checks passed
@stiiifff stiiifff deleted the sde/release-tweaks branch January 24, 2025 16:08
purestakeoskar
purestakeoskar reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@purestakeoskar purestakeoskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purestakeoskar purestakeoskar purestakeoskar left review comments

@timbrinded timbrinded timbrinded approved these changes

@RomarQ RomarQ RomarQ left review comments

@pLabarta pLabarta pLabarta left review comments

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stiiifff @pLabarta @RomarQ @purestakeoskar @timbrinded