-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add genesis config presets to runtime #3138
base: master
Are you sure you want to change the base?
Add genesis config presets to runtime #3138
Conversation
WASM runtime size check:Compared to target branchMoonbase runtime: 2420 KB (+148 KB) 🚨 Moonbeam runtime: 2404 KB (+152 KB) 🚨 Moonriver runtime: 2400 KB (+156 KB) Compared to latest release (runtime-3401)Moonbase runtime: 2420 KB (+388 KB compared to latest release) 🚨 Moonbeam runtime: 2404 KB (+392 KB compared to latest release) 🚨 Moonriver runtime: 2400 KB (+388 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master manuel/update-deprecation-in-benchmarks-script +/- ##
==================================================================================
+ Coverage 74.58% 74.59% +0.01%
+ Files 377 380 +3
- Lines 96042 96035 -7
==================================================================================
Hits 71632 71632
- Misses 24410 24403 -7
|
…mand within the script
This reverts commit 52436cb.
LGTM 🚀 |
Just noticed that this change increases the runtime size in around 140KB, would be nice if we could optimize things a little. |
About the wasm size increase, we should remove all presets by using a new feature moonbeam/runtime/moonbase/Cargo.toml Line 340 in 1a0c3d4
moonbeam/runtime/moonbeam/Cargo.toml Line 329 in 1a0c3d4
moonbeam/runtime/moonriver/Cargo.toml Line 334 in 1a0c3d4
|
What does it do?
When running
run-benches-for-runtime.sh
to generate the runtime weights, the following warning appears in the logs:This PR updates the script to use
--runtime <runtime>
instead of--chain=<chain-spec>
.In order to address the issue above, we need move the creation of the genesis config presets to the runtime. (Example PR on polkadot-sdk)
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?