Test 🧪: add accessList gas cost tests #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pLabarta
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2420 KB (no changes) 🚨 Moonbeam runtime: 2404 KB (no changes) 🚨 Moonriver runtime: 2392 KB (no changes) ✅ Compared to latest release (runtime-3401)Moonbase runtime: 2420 KB (+388 KB compared to latest release) 🚨 Moonbeam runtime: 2404 KB (+392 KB compared to latest release) 🚨 Moonriver runtime: 2392 KB (+380 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master pablo/access-list-test +/- ##
=========================================================
Coverage 74.59% 74.59% 0.00%
Files 380 380
Lines 96029 96029
=========================================================
Hits 71632 71632
Misses 24397 24397
|
TarekkMA
previously approved these changes
Jan 17, 2025
test/suites/dev/moonbase/test-eth-tx/test-eth-tx-access-list.ts
Outdated
Show resolved
Hide resolved
test/suites/dev/moonbase/test-eth-tx/test-eth-tx-access-list.ts
Outdated
Show resolved
Hide resolved
RomarQ
reviewed
Jan 22, 2025
TarekkMA
approved these changes
Jan 22, 2025
stiiifff
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR adds test for 3 cases related to the
accessListtransaction field introduced in EIP-2930 and implemented through theevmpallet in order to confirm that the field does not present an attack vector for Moonbeam networks. In Moonbeam tho, behavior is somewhat different from the expected for the first 4 addresses and storage keys added to the access list of a transaction; costing less than expected.Cases are the following:
Is there something left for follow-up PRs?
While working on these tests it was detected that transactions using the
accessListfield cost more gas that those without it, even when reusing the same storage and addresses multiple times. This means the feature does not work as expected as it is meant to allow users to save some gas by pre-warming the storage they will access.