Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update xcm transactor for the overall weight changes #849

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Jan 15, 2024

Description

This PR updates the XCM Transactor pallet and precompile docs, as the overallWeight arg can now be set to unlimited -- as of runtime 2700

Checklist

  • I have added a label to this PR 🏷️
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
    • part of the XCM overhaul

After Translation Requirements

  • No additional PRs are required after the translations are done

@eshaben eshaben added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Jan 15, 2024
@eshaben eshaben requested a review from themacexpert January 15, 2024 03:25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! While you're in here can you fix the "does not need to be register" typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it! thank you!!

Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshaben eshaben merged commit 0c8a830 into master Jan 16, 2024
1 check passed
@eshaben eshaben deleted the eshaben/tranasctor-overall-weight branch January 16, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants