Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brownie updates #840

Merged
merged 18 commits into from
Jan 16, 2024
Merged

Brownie updates #840

merged 18 commits into from
Jan 16, 2024

Conversation

themacexpert
Copy link
Contributor

@themacexpert themacexpert commented Jan 8, 2024

Description

While working on the Brownie test suite I found a few things that needed to be updated on the Brownie docs page.

Goes with moonbeam-foundation/moonbeam-docs-cn#395

Just as a reference,
moonbase refers to moonbeam local node in Brownie's terminology and moonbeam-test is Moonbase Alpha

Checklist

  • I have added a label to this PR 🏷️
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert requested a review from eshaben January 8, 2024 23:53
@themacexpert themacexpert added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Jan 8, 2024
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so I think our hands are tied at this point. I saw the PR you opened to change the RPC urls. I'm not very optimistic that it will get merged since the last PR was merged maybe in June of last year.

I'll look into how many views we get on this page and get back to you. I'm thinking we might need to sunset this page.

builders/build/eth-api/dev-env/brownie.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/brownie.md Outdated Show resolved Hide resolved
@themacexpert themacexpert requested a review from eshaben January 11, 2024 03:57
builders/build/eth-api/dev-env/brownie.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/brownie.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/brownie.md Outdated Show resolved Hide resolved
@themacexpert
Copy link
Contributor Author

Added the termynal sections in to replace the screenshots!

@themacexpert themacexpert requested a review from eshaben January 12, 2024 03:52
@eshaben
Copy link
Contributor

eshaben commented Jan 15, 2024

thanks for adding the termynal snippets!!! also, can you please update the termynal snippets to match the changes made in this PR?

@themacexpert themacexpert requested a review from eshaben January 15, 2024 23:16
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!! 🙌

@eshaben eshaben merged commit abacacc into master Jan 16, 2024
1 check passed
@eshaben eshaben deleted the themacexpert/updateBrownie branch January 16, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants