Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scaffold-eth docs to v2 #816

Merged
merged 2 commits into from
Dec 14, 2023
Merged

update scaffold-eth docs to v2 #816

merged 2 commits into from
Dec 14, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Dec 13, 2023

Description

This PR updates scaffold-eth to v2 as v1 has been archived.

Checklist

  • I have added a label to this PR 🏷️
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If images have been added, I have run the compress-images.py script to compress the images.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images

Items to be Updated

Remove all images in the scaffold-eth directory and replace with the ones in the new directory

@eshaben eshaben added the A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) label Dec 13, 2023
@eshaben eshaben requested a review from themacexpert December 13, 2023 06:25
@eshaben
Copy link
Contributor Author

eshaben commented Dec 13, 2023

I created a PR for the scaffold-eth-2 repository to add Moonbeam networks to the Hardhat config. So, if that gets accepted, the instructions will need to be updated slightly

Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

builders/build/eth-api/dev-env/scaffold-eth.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/scaffold-eth.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/scaffold-eth.md Outdated Show resolved Hide resolved
@eshaben eshaben merged commit 9eba1bd into master Dec 14, 2023
1 check passed
@eshaben eshaben deleted the eshaben/scaffold-eth branch December 14, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants