Resolve issue with the MetaMask button #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themacexpert
previously approved these changes
Jan 24, 2025
themacexpert
added
the
B1 - Ready to be Merged
eshaben
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Sweeeet! It's working now!
On the Connect MetaMask page, after you connect to a network, the button text doesn't change to show "Connected <shortened_account_here>" and disables the button like it does in the modal. So ideally, that should be added in because if I am already connected to a network, but I try to click the button again, nothing happens. I don't think anyone would do this haha, but you never know. Anyways, so if the button was disabled, this issue would be avoided.
eshaben
added
A2 - Maintenance Minor
Co-authored-by: Erin Shaben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a missing event listener for the
.connectMetaMaskbutton in the body so it calls the sameconnectNetworkfunction used by the nav button. This ensures that the body button now correctly connects to the specified network.Checklist
moonbeam-mkdocsto update redirects