Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds EVM contract metadata migration to historical updates page #1043

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Adds EVM contract metadata migration to historical updates page #1043

wants to merge 7 commits into from

Conversation

dawnkelly09
Copy link
Contributor

Description

This PR:

  • adds headings ### EVM Pallet and #### EVM Contract Metadata
  • adds the EVM Contract Metadata migration information to the historical updates page

Corresponding PRs

This PR describes changes made here: https://github.com/moonbeam-foundation/moonbeam/pull/2919/files

@dawnkelly09 dawnkelly09 added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Dec 18, 2024
themacexpert
themacexpert requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing! ty

builders/build/historical-updates.md Outdated Show resolved Hide resolved
themacexpert
themacexpert previously approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

eshaben
eshaben reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions, but looks good!

builders/build/historical-updates.md Outdated Show resolved Hide resolved
builders/build/runtime-upgrades.md Show resolved Hide resolved
builders/build/runtime-upgrades.md Outdated Show resolved Hide resolved
builders/build/historical-updates.md Show resolved Hide resolved
@dawnkelly09
Copy link
Contributor Author

Cleared the merge conflicts. This should be ready to go pending @themacexpert confirming here: #1043 (comment)

@themacexpert
Copy link
Contributor

Cleared the merge conflicts. This should be ready to go pending @themacexpert confirming here: #1043 (comment)

Correct we did not update Moonbase, only Moonriver and Moonbeam

@themacexpert themacexpert self-requested a review January 7, 2025 22:00
themacexpert
themacexpert requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dawnkelly09 Can you please double check that all your changes are included in this PR ? For some reason it is only showing one line of changes...

Screenshot 2025-01-07 at 1 58 57 PM

A similar thing happened to me on #1055 and I just created a new PR.

@dawnkelly09
Copy link
Contributor Author

@dawnkelly09 Can you please double check that all your changes are included in this PR ? For some reason it is only showing one line of changes...

Thank you! I chose the wrong path when clearing merge conflicts I think. Added back with this last commit.

themacexpert
themacexpert requested changes Jan 8, 2025
View reviewed changes
builders/build/historical-updates.md Outdated Show resolved Hide resolved
themacexpert
themacexpert approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@themacexpert themacexpert added the B1 - Ready to be Merged Pull request is ready to be merged label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben left review comments

@themacexpert themacexpert themacexpert approved these changes

Assignees
No one assigned
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to be Merged Pull request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dawnkelly09 @themacexpert @eshaben