Add markdown element #239
Merged
Add markdown element #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximehuran
force-pushed
the
feature/add-markdown-element
branch
from
84c386f to
f887e11
Compare
maximehuran
force-pushed
the
feature/add-markdown-element
branch
from
c52fea8 to
95a58db
Compare
maximehuran
requested review from
delyriand,
welcoMattic,
jacquesbh and
lanfisis
maximehuran
removed request for
delyriand,
welcoMattic,
jacquesbh and
lanfisis
jacquesbh
requested changes
Sep 5, 2024
madamebiz
added
Status: needs update
madamebiz
added
Status: needs review
maximehuran
commented
Sep 5, 2024
delyriand
approved these changes
Sep 6, 2024
lanfisis
approved these changes
Sep 6, 2024
welcoMattic
reviewed
Sep 6, 2024
Co-authored-by: Mathieu Santostefano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add markdown UI Element
This version will require
twig/extra-bundlewhich will generate an error with Sylius Standard setup :The recipe will run a script which comment this line :
https://github.com/monsieurbiz/symfony-recipes/blob/master/monsieurbiz/sylius-rich-editor-plugin/2.9/manifest.json#L10
See Sylius/Sylius-Standard#1021 for more information
The Ui Element
Add highlight JS in shop
You can enable or disable and change highlight JS theme :
No higlight in admin for now.
We have to manage the load after the AJAX call to render elements.
Custom theme
The default theme is loaded in local.
Another themes are loaded via CDN.
Example with
atom-one-dark