Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Sylius 1.11 to 1.13 #231

Merged
merged 10 commits into from
Jul 2, 2024

Conversation

maximehuran
Copy link
Member

@maximehuran maximehuran commented Jun 18, 2024

closes #189 #228 #169

Sylius 1.13 compatibility

image

Youtube shorts compatibility

image

image

Avoid error if folder media/rich-editor does not exists

The liip imagine folder can not exists and it will be ignored

image

@maximehuran maximehuran force-pushed the feature/sylius-1-13 branch from 8dbad33 to 5a4af4d Compare June 18, 2024 19:45
@madamebiz madamebiz added Status: needs review Status: needs review labels Jun 24, 2024
README.md Outdated Show resolved Hide resolved
src/UiElement/UiElementFormOptionsTrait.php Outdated Show resolved Hide resolved
src/UiElement/UiElementTrait.php Outdated Show resolved Hide resolved
@madamebiz madamebiz added Status: needs update This Issue/PR needs update and removed Status: needs review Status: needs review labels Jun 28, 2024
@maximehuran maximehuran requested a review from Kiwikoti July 2, 2024 09:31
@madamebiz madamebiz added Status: needs review Status: needs review and removed Status: needs update This Issue/PR needs update labels Jul 2, 2024
Copy link
Contributor

@Kiwikoti Kiwikoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximehuran maximehuran merged commit a0c428d into monsieurbiz:master Jul 2, 2024
10 checks passed
@maximehuran maximehuran deleted the feature/sylius-1-13 branch July 2, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: needs review Status: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle shorts Youtube link
4 participants