Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch form PEL to SunEditor as default WYSIWYG editor #219

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Switch form PEL to SunEditor as default WYSIWYG editor #219

merged 6 commits into from
Apr 25, 2024

Conversation

lanfisis
Copy link
Member

@lanfisis lanfisis commented Apr 4, 2024

Two main things of this PR:

  • add capability to add new WYSIWYG (more) easily with a thin abstraction layer
  • add suneditor.js as the default WYSIWYG instead of PELL

Screenshots

image image image

@madamebiz madamebiz added the Status: needs review Status: needs review label Apr 4, 2024
delyriand
delyriand requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@delyriand delyriand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ question: ‏isn't it possible to keep the peel in editor (default for transition time?) in addition to SunEditor?

@madamebiz madamebiz added Status: needs update This Issue/PR needs update and removed Status: needs review Status: needs review labels Apr 5, 2024
maximehuran
maximehuran approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@maximehuran maximehuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to release it with 2.5.0 version and may write an upgrade guide if needed

@Kiwikoti Kiwikoti removed their request for review April 11, 2024 07:38
@maximehuran
Copy link
Member

❔ question: ‏isn't it possible to keep the peel in editor (default for transition time?) in addition to SunEditor?

We can also try if we had some content from Pell, and we switch to the new editor, nothing is broken.
I think Pell editor will miss to nobody 😅

@lanfisis
Copy link
Member Author

❔ question: ‏isn't it possible to keep the peel in editor (default for transition time?) in addition to SunEditor?

I think as @maximehuran that we should forget PEL. The ever created PEL HTML content are very simple because PEL is simple and there is no problem to display it on SunEditor

@lanfisis lanfisis requested a review from delyriand April 17, 2024 10:01
@madamebiz madamebiz added Status: needs review Status: needs review and removed Status: needs update This Issue/PR needs update labels Apr 17, 2024
@maximehuran maximehuran requested a review from Kiwikoti April 17, 2024 12:05
@lanfisis lanfisis merged commit 293b0f2 into monsieurbiz:master Apr 25, 2024
10 checks passed
@maximehuran maximehuran mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiwikoti Kiwikoti Kiwikoti approved these changes

@maximehuran maximehuran maximehuran approved these changes

@delyriand delyriand delyriand approved these changes

Assignees
No one assigned
Labels
Status: needs review Status: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lanfisis @maximehuran @delyriand @Kiwikoti @madamebiz