add biome errorformat

.github/workflows/test.yml

@@ -4,49 +4,101 @@ on:
     branches:
       - main
   pull_request:
-# TODO: replace `<linter-name>` with yours
 jobs:
   test-check:
-    name: runner / <linter-name> (github-check)
+    name: runner / Biome (github-check)
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: ./
+      - id: action-success-test
+        name: action-success-test
+        uses: ./
         with:
           github_token: ${{ secrets.github_token }}
+          workdir: ./testdata
+          reporter: github-check
+          level: error
+          filter_mode: nofilter
+          fail_on_error: true
+          biome_flags: ok
+      - id: action-failure-test
+        name: action-failure-test
+        uses: ./
+        continue-on-error: true
+        with:
+          github_token: ${{ secrets.github_token }}
+          workdir: ./testdata
           reporter: github-check
           level: info
-          locale: "US"
+          filter_mode: nofilter
+          fail_on_error: true
+          biome_flags: error
+      - name: check-failure
+        if: steps.action-failure-test.outcome == 'success'
+        run: exit 1
 
   test-pr-check:
     if: github.event_name == 'pull_request'
-    name: runner / <linter-name> (github-pr-check)
+    name: runner / Biome (github-pr-check)
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: ./
+      - id: action-success-test
+        name: action-success-test
+        uses: ./
+        with:
+          github_token: ${{ secrets.github_token }}
+          workdir: ./testdata
+          reporter: github-pr-check
+          level: error
+          filter_mode: nofilter
+          fail_on_error: true
+          biome_flags: ok
+      - id: action-failure-test
+        name: action-failure-test
+        uses: ./
+        continue-on-error: true
         with:
           github_token: ${{ secrets.github_token }}
+          workdir: ./testdata
           reporter: github-pr-check
-          level: warning
-          locale: "US"
-          workdir: ./testdata/subdir/
+          level: info
+          filter_mode: nofilter
+          fail_on_error: true
+          biome_flags: error
+      - name: check-failure
+        if: steps.action-failure-test.outcome == 'success'
+        run: exit 1
 
   test-pr-review:
     if: github.event_name == 'pull_request'
-    name: runner / <linter-name> (github-pr-review)
+    name: runner / Biome (github-pr-review)
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: ./
-        continue-on-error: true
+      - id: action-success-test
+        name: action-success-test
+        uses: ./
         with:
           github_token: ${{ secrets.github_token }}
+          workdir: ./testdata
           reporter: github-pr-review
           level: error
-          locale: "US"
-          filter_mode: file
+          filter_mode: nofilter
+          fail_on_error: true
+          biome_flags: ok
+      - id: action-failure-test
+        name: action-failure-test
+        uses: ./
+        continue-on-error: true
+        with:
+          github_token: ${{ secrets.github_token }}
+          workdir: ./testdata
+          reporter: github-pr-review
+          level: info
+          filter_mode: nofilter
           fail_on_error: true
-      - name: check the exit code
-        if: ${{ !success() }}
-        run: echo 'The previous step should fail' && exit 1
+          biome_flags: error
+      - name: check-failure
+        if: steps.action-failure-test.outcome == 'success'
+        run: exit 1

.gitignore

@@ -1,2 +1,4 @@
 # Folders to ignore
-.vscode/
+.vscode/
+.idea/
+node_modules/

README.md

@@ -1,44 +1,25 @@
-# action-composite-template
+# reviewdog-action-biome
 
-<!-- TODO: replace reviewdog/action-composite-template with your repo name -->
-[![Test](https://github.com/reviewdog/action-composite-template/workflows/Test/badge.svg)](https://github.com/reviewdog/action-composite-template/actions?query=workflow%3ATest)
-[![reviewdog](https://github.com/reviewdog/action-composite-template/workflows/reviewdog/badge.svg)](https://github.com/reviewdog/action-composite-template/actions?query=workflow%3Areviewdog)
-[![depup](https://github.com/reviewdog/action-composite-template/workflows/depup/badge.svg)](https://github.com/reviewdog/action-composite-template/actions?query=workflow%3Adepup)
-[![release](https://github.com/reviewdog/action-composite-template/workflows/release/badge.svg)](https://github.com/reviewdog/action-composite-template/actions?query=workflow%3Arelease)
-[![GitHub release (latest SemVer)](https://img.shields.io/github/v/release/reviewdog/action-composite-template?logo=github&sort=semver)](https://github.com/reviewdog/action-composite-template/releases)
-[![action-bumpr supported](https://img.shields.io/badge/bumpr-supported-ff69b4?logo=github&link=https://github.com/haya14busa/action-bumpr)](https://github.com/haya14busa/action-bumpr)
+This action runs [Biome](https://biomejs.dev/) with [reviewdog](https://github.com/reviewdog/reviewdog) on pull requests to improve code review experience.
 
-![github-pr-review demo](https://user-images.githubusercontent.com/3797062/73162963-4b8e2b00-4132-11ea-9a3f-f9c6f624c79f.png)
-![github-pr-check demo](https://user-images.githubusercontent.com/3797062/73163032-70829e00-4132-11ea-8481-f213a37db354.png)
-
-<!-- TODO: outline your action here -->
-This is a template repository for
-[reviewdog](https://github.com/reviewdog/reviewdog) action with release
-automation based on [action composition](https://docs.github.com/en/actions/creating-actions/creating-a-composite-action).
-Click `Use this template` button to create your reviewdog action :dog:!
-
-If you want to create your own reviewdog action from scratch without using this
-template, please check and copy release automation flow.
-It's important to manage release workflow and sync reviewdog version for all
-reviewdog actions.
-
-This repo contains a sample action to run [misspell](https://github.com/client9/misspell).
 
 ## Input
 
-<!-- TODO: replace `<linter-name>` with yours -->
 ```yaml
 inputs:
   github_token:
     description: 'GITHUB_TOKEN'
     default: '${{ github.token }}'
   workdir:
-    description: 'Working directory relative to the root directory.'
+    description: |
+      Working directory relative to the root directory.
+      This is where the action will look for a package.json file which declares Biome as a dependency.
+      Please note that this is different from the directory where the action will run Biome, which is specified in the biome_flags input.
     default: '.'
   ### Flags for reviewdog ###
   tool_name:
     description: 'Tool name to use for reviewdog reporter.'
-    default: '<linter-name>'
+    default: 'Biome'
   level:
     description: 'Report level for reviewdog [info,warning,error].'
     default: 'error'
@@ -58,26 +39,24 @@ inputs:
   reviewdog_flags:
     description: 'Additional reviewdog flags.'
     default: ''
-  ### Flags for <linter-name> ###
-  locale:
-    description: '-locale flag of misspell. (US/UK)'
-    default: ''
+  ### Flags for Biome ###
+  biome_flags:
+    description: 'Flags and args for Biome command.'
+    default: '.'
 ```
 
 ## Usage
-<!-- TODO: replace reviewdog/action-composite-template with your repo name -->
 
 ```yaml
 name: reviewdog
 on: [pull_request]
 jobs:
-  # TODO: replace `linter_name` and `<linter-name>` with yours
   linter_name:
-    name: runner / <linter-name>
+    name: runner / Biome
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: reviewdog/action-composite-template@v1
+      - uses: mongolyy/reviewdog-action-biome@v1
         with:
           github_token: ${{ secrets.github_token }}
           # Change reviewdog reporter if you need [github-check,github-pr-review,github-pr-check].

action.yml

@@ -1,18 +1,20 @@
-# TODO: replace `<linter-name>` and `<your-name>` with yours
-name: 'Run <linter-name> with reviewdog'
-description: '🐶 Run <linter-name> with reviewdog on pull requests to improve code review experience.'
-author: '<your-name>'
+name: 'Run Biome with reviewdog'
+description: '🐶 Run Biome with reviewdog on pull requests to improve code review experience.'
+author: 'mongolyy'
 inputs:
   github_token:
     description: 'GITHUB_TOKEN'
     default: '${{ github.token }}'
   workdir:
-    description: 'Working directory relative to the root directory.'
+    description: |
+      Working directory relative to the root directory.
+      This is where the action will look for a package.json file which declares Biome as a dependency.
+      Please note that this is different from the directory where the action will run Biome, which is specified in the biome_flags input.
     default: '.'
   ### Flags for reviewdog ###
   tool_name:
     description: 'Tool name to use for reviewdog reporter.'
-    default: '<linter-name>'
+    default: 'Biome'
   level:
     description: 'Report level for reviewdog [info,warning,error].'
     default: 'error'
@@ -32,16 +34,16 @@ inputs:
   reviewdog_flags:
     description: 'Additional reviewdog flags.'
     default: ''
-  ### Flags for <linter-name> ###
-  locale:
-    description: '-locale flag of misspell. (US/UK)'
-    default: ''
+  ### Flags for Biome ###
+  biome_flags:
+    description: 'Flags and args for Biome command.'
+    default: '.'
 runs:
   using: 'composite'
   steps:
     - uses: reviewdog/action-setup@v1
       with:
-        reviewdog_version: v0.15.0
+        reviewdog_version: v0.16.0
     - run: $GITHUB_ACTION_PATH/script.sh
       shell: bash
       env:
@@ -55,10 +57,9 @@ runs:
         INPUT_FILTER_MODE: ${{ inputs.filter_mode }}
         INPUT_FAIL_ON_ERROR: ${{ inputs.fail_on_error }}
         INPUT_REVIEWDOG_FLAGS: ${{ inputs.reviewdog_flags }}
-        INPUT_LOCALE: ${{ inputs.locale }}
+        INPUT_BIOME_FLAGS: ${{ inputs.biome_flags }}
 
 # Ref: https://haya14busa.github.io/github-action-brandings/
-# TODO: update branding if you want.
 branding:
   icon: 'check'
   color: 'blue'

script.sh

@@ -7,22 +7,35 @@ fi
 
 export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}"
 
-echo '::group::🐶 Installing misspell ... https://github.com/client9/misspell'
-TEMP_PATH="$(mktemp -d)"
-PATH="${TEMP_PATH}:$PATH"
-wget -O - -q https://git.io/misspell | sh -s -- -b "${TEMP_PATH}"
-echo '::endgroup::'
+if [ ! -f "$(npm root)"/.bin/biome ]; then
+  echo '::group::🐶 Installing Biome...'
+  npm install
+  echo '::endgroup::'
+fi
+
+if [ ! -f "$(npm root)"/.bin/biome ]; then
+  echo "❌ Unable to locate or install Biome. Did you provide a workdir which contains a valid package.json?"
+  exit 1
+fi
+
+echo "Biome $("$(npm root)"/.bin/biome --version)"
 
-echo '::group:: Running misspell with reviewdog 🐶 ...'
-# shellcheck disable=SC2086
-misspell -locale="${INPUT_LOCALE}" . |
-  reviewdog -efm="%f:%l:%c: %m" \
+echo '::group:: Running Biome with reviewdog 🐶 ...'
+"$(npm root)"/.bin/biome ci "${INPUT_BIOME_FLAGS}" 2>&1 |
+  reviewdog \
+    -efm="%C" \
+    -efm="%-Gci ━%#" \
+    -efm="%E%f:%l:%c %.%#━" \
+    -efm="%Z  × %m" \
+    -efm="%E%f %m %.%#━" \
+    -efm="%Z  × %m" \
+    -efm="%-G%.%#" \
     -name="${INPUT_TOOL_NAME}" \
     -reporter="${INPUT_REPORTER}" \
     -filter-mode="${INPUT_FILTER_MODE}" \
     -fail-on-error="${INPUT_FAIL_ON_ERROR}" \
     -level="${INPUT_LEVEL}" \
-    ${INPUT_REVIEWDOG_FLAGS}
+    "${INPUT_REVIEWDOG_FLAGS}"
 exit_code=$?
 echo '::endgroup::'
 exit $exit_code

testdata/error/format.css

@@ -0,0 +1,5 @@
+html {}
+
+div { color: white;}
+
+div { color: white; background-color: red;}

testdata/error/format.js

@@ -0,0 +1 @@
+const a = [2,2,1,3];

testdata/error/lint.css

@@ -0,0 +1,3 @@
+@font-face foo {}
+@font-face foo;
+@font-face ;

testdata/error/lint.js

@@ -0,0 +1,5 @@
+[a a, ++b, ] = test;
+[a, c, ...rest,] = test;
+[a = , = "test"] = test;
+[[a b] [c]]= test;
+[a: b] = c

testdata/ok/format.css

@@ -0,0 +1,11 @@
+html {
+}
+
+div {
+  color: white;
+}
+
+div {
+  color: white;
+  background-color: red;
+}

testdata/ok/format.js

@@ -0,0 +1 @@
+const a = [2, 2, 1, 3];

testdata/ok/lint.css

@@ -0,0 +1 @@
+@font-face {}

testdata/ok/lint.js

@@ -0,0 +1 @@
+[foo, bar] = baz;