CLOUDP-283513: IP Access List new resource #3586
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderjs
changed the base branch from
master
to
CLOUDP-296579-ako-flex-generation
|
Coverage Report 📉
|
s-urbaniak
reviewed
Feb 6, 2025
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/mongodb/mongodb-atlas-cli/atlascli | |||
|
|
|||
| go 1.23.1 | |||
| go 1.23.5 | |||
There was a problem hiding this comment.
not sure if this is wanted
s-urbaniak
reviewed
Feb 6, 2025
go.mod
Outdated
| @@ -30,7 +30,7 @@ require ( | |||
| github.com/mholt/archives v0.1.0 | |||
| github.com/mongodb-forks/digest v1.1.0 | |||
| github.com/mongodb-labs/cobra2snooty v0.18.2 | |||
| github.com/mongodb/mongodb-atlas-kubernetes/v2 v2.6.2-0.20250123164100-b8aa5669900f | |||
| github.com/mongodb/mongodb-atlas-kubernetes/v2 v2.6.2-0.20250129015533-7920f411a73e | |||
There was a problem hiding this comment.
i would expect 2.7.0 in here
s-urbaniak
approved these changes
Feb 6, 2025
helderjs
force-pushed
the
CLOUDP-296579-ako-flex-generation
branch
from
b38f566 to
be8d06a
Compare
helderjs
force-pushed
the
CLOUDP-283513-ip-access-list
branch
from
68e4d98 to
80d1bdc
Compare
helderjs
force-pushed
the
CLOUDP-283513-ip-access-list
branch
from
80d1bdc to
dde3a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR add the support to export the new custom resource for IP Access List
Jira ticket: CLOUDP-283513
Checklist
make fmtand formatted my code