Fix build with boost ASIO 1.87. Support boost 1.66+ #9628
Merged
+397
−375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnerd
commented
Dec 17, 2024
|
(This needs #9162 to pass depends CI. I will undraft that PR after the next round of merges.) |
vtnerd
force-pushed
the
fix/boost_1.87_squashed
branch
from
8c98c45 to
e88e61d
Compare
|
The latest force push should work with Boost 1.66-1.87. Something funky happened with the tests, so I may push a dummy change later to see what happens. |
|
https://github.com/tobtoht/monero/actions/runs/12390979989/job/34587144842#step:5:1281 Looks like |
jeffro256
reviewed
Dec 18, 2024
vtnerd
force-pushed
the
fix/boost_1.87_squashed
branch
from
e88e61d to
f185187
Compare
|
Fore pushed some changes:
|
vtnerd
force-pushed
the
fix/boost_1.87_squashed
branch
2 times, most recently
from
1c62d08 to
da62d98
Compare
|
Force pushed twice with updates:
|
vtnerd
force-pushed
the
fix/boost_1.87_squashed
branch
from
da62d98 to
a0ce1e9
Compare
|
Force pushed an include fix. |
|
This patch looks ready. The depends CI will all fail until #9162 gets merged. I will leave as draft for now for that reason. |
selsta
reviewed
Dec 23, 2024
|
Once this is ready for review, please remove Draft status. |
vtnerd
force-pushed
the
fix/boost_1.87_squashed
branch
2 times, most recently
from
625f370 to
0452910
Compare
|
Force pushed:
Likely this will get removed as draft, assuming some of the tests cycle green. |
vtnerd
force-pushed
the
fix/boost_1.87_squashed
branch
from
0452910 to
ad7eaaa
Compare
Forgot to update this in the last force push, so another quick push with this change. |
|
Now ready for review. |
|
Getting a ton of build errors across many platforms: |
|
The dependencies system seems to still be pulling Boost 1.64 instead of 1.66 on these failed platforms |
|
@jeffro256 requires #9162 to be merged first |
|
Sorry, my bad. Should've read farther up in the comments |
0xFFFC0000
reviewed
Dec 27, 2024
There was a problem hiding this comment.
From technical perspective, everything is great, and I don't see any specific issues.
The only remaining thing is I have to fetch #9162 and compile, and run all the tests.
jeffro256
suggested changes
Dec 27, 2024
This was referenced Jan 6, 2025
vtnerd
force-pushed
the
fix/boost_1.87_squashed
branch
2 times, most recently
from
6c9b047 to
e26444c
Compare
vtnerd
force-pushed
the
fix/boost_1.87_squashed
branch
from
e26444c to
4344f97
Compare
jeffro256
approved these changes
Jan 7, 2025
tobtoht
approved these changes
Jan 7, 2025
Doy-lee
pushed a commit
to Doy-lee/loki
that referenced
this pull request
Jan 9, 2025
MSYS now packages boost 1.87 which we don't support due to our dependence on epee and their usage of 'asio::io_service' which was deprecated in 1.87. To allow 1.87 we would need to port in changes from Monero, i.e. see monero-project#9628 which may or may not be considered at some point but certainly not now.
Doy-lee
pushed a commit
to Doy-lee/loki
that referenced
this pull request
Jan 13, 2025
MSYS now packages boost 1.87 which we don't support due to our dependence on epee and their usage of 'asio::io_service' which was deprecated in 1.87. To allow 1.87 we would need to port in changes from Monero, i.e. see monero-project#9628 which may or may not be considered at some point but certainly not now.
selsta
approved these changes
Jan 14, 2025
Doy-lee
pushed a commit
to Doy-lee/loki
that referenced
this pull request
Jan 15, 2025
MSYS now packages boost 1.87 which we don't support due to our dependence on epee and their usage of 'asio::io_service' which was deprecated in 1.87. To allow 1.87 we would need to port in changes from Monero, i.e. see monero-project#9628 which may or may not be considered at some point but certainly not now.
Doy-lee
pushed a commit
to Doy-lee/loki
that referenced
this pull request
Jan 16, 2025
MSYS now packages boost 1.87 which we don't support due to our dependence on epee and their usage of 'asio::io_service' which was deprecated in 1.87. To allow 1.87 we would need to port in changes from Monero, i.e. see monero-project#9628 which may or may not be considered at some point but certainly not now.
Doy-lee
pushed a commit
to Doy-lee/loki
that referenced
this pull request
Jan 17, 2025
MSYS now packages boost 1.87 which we don't support due to our dependence on epee and their usage of 'asio::io_service' which was deprecated in 1.87. To allow 1.87 we would need to port in changes from Monero, i.e. see monero-project#9628 which may or may not be considered at some point but certainly not now.
Doy-lee
pushed a commit
to Doy-lee/loki
that referenced
this pull request
Jan 17, 2025
MSYS now packages boost 1.87 which we don't support due to our dependence on epee and their usage of 'asio::io_service' which was deprecated in 1.87. To allow 1.87 we would need to port in changes from Monero, i.e. see monero-project#9628 which may or may not be considered at some point but certainly not now.
Doy-lee
pushed a commit
to oxen-io/oxen-core
that referenced
this pull request
Jan 20, 2025
MSYS now packages boost 1.87 which we don't support due to our dependence on epee and their usage of 'asio::io_service' which was deprecated in 1.87. To allow 1.87 we would need to port in changes from Monero, i.e. see monero-project#9628 which may or may not be considered at some point but certainly not now.
|
@selsta should this be done on the release branch? I don't remember what was decided. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should compile with Boost 1.73-1.87. I have only tested on Boost 1.74 and Boost 1.87 (primarily unit tests). I will mark the places where I know changes need to be made for older boost versions. I will clear up all such errors by manually downloading Boost 1.66 and testing.
One problem I have with supporting Boost 1.66-1.69 is that most types require an io_context object, whereas Boost 1.70+ have relaxed this requirement to an executor object. I will show an example of where it matters; it will be easy to break older Boost versions unintentionally.
EDIT:
This is currently marked as a draft, because the depends build will fail until #9162 gets merged (which is also marked as draft).