-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add id to CVSS score #5163
base: main
Are you sure you want to change the base?
🐛 Add id to CVSS score #5163
Conversation
This fixes issues with the vulnmgmt resources, where the score might show as 0. Signed-off-by: Christian Zunker <[email protected]>
Before:
After:
|
providers/os/resources/vulnmgmt.go
Outdated
@@ -309,3 +310,8 @@ func (p *mqlVulnPackage) id() (string, error) { | |||
id := p.Name.Data + "-" + p.Version.Data | |||
return id, p.Name.Error | |||
} | |||
|
|||
func (a *mqlAuditCvss) id() (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend, we do not define id
but instead set the id via __id
in https://github.com/mondoohq/cnquery/pull/5163/files#diff-28c35fab103e7ef63642bb4193f79aaf83371624b83044f910bb27bb60909414R195
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks. I wasn't aware this is possible. I changed the code.
Signed-off-by: Christian Zunker <[email protected]>
cd82a38
to
5346127
Compare
This fixes issues with the vulnmgmt resources, where the score might show as 0.