🐛 github: fix precedence flag vs env-var #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github provide has two authentication methods. 1. Application credentials 2. Personal access token We give precedence to the former and, if both auth methods are provided, we will output a warning. Closes #5036 Signed-off-by: Salim Afiune Maya <[email protected]>
vjeffrey
reviewed
Jan 31, 2025
| } | ||
| if token == "" && !isAppAuth { | ||
| return nil, errors.New("a valid GitHub authentication is required, pass --token '<yourtoken>', set GITHUB_TOKEN environment variable or provide GitHub App credentials") | ||
| } | ||
| if token != "" { | ||
| if isAppAuth { | ||
| log.Warn().Msg("both authentication methods provided, using application credentials") |
There was a problem hiding this comment.
it looks like here we warn that we're going to use the application credentials but then set the token as the credential? is that correct?
There was a problem hiding this comment.
That is correct. We can also NOT set it, it is a noop at this time so, more like a preference.
There was a problem hiding this comment.
ok. i do find it confusing to set it if we're not using it, but things are working 👍
There was a problem hiding this comment.
Will not set it to avoid confusion. 👍🏽
vjeffrey
approved these changes
Feb 4, 2025
Signed-off-by: Salim Afiune Maya <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github provider has two authentication methods.
We give precedence to the former and, if both auth methods are provided,
we will output a warning.
Closes #5036