-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 refactor languages #5120
Merged
Merged
🧹 refactor languages #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/languages
branch
from
January 26, 2025 15:08
41d5d03
to
382a33e
Compare
Test Results3 206 tests - 3 3 202 ✅ - 3 2m 8s ⏱️ +27s Results for commit ca6ce7a. ± Comparison against base commit e663232. This pull request removes 48 and adds 45 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
chris-rock
force-pushed
the
chris-rock/languages
branch
from
January 26, 2025 15:12
382a33e
to
b1c9721
Compare
imilchev
approved these changes
Jan 28, 2025
imilchev
force-pushed
the
chris-rock/languages
branch
from
January 28, 2025 10:16
b51d84d
to
6ceda4d
Compare
Signed-off-by: Ivan Milchev <[email protected]>
imilchev
force-pushed
the
chris-rock/languages
branch
from
January 28, 2025 10:20
6ceda4d
to
ca6ce7a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to harmonize the python and the npm packages resources. This PR moves the helper code into the
languages
packages to parse the dependencies. We also extract the filesystem walking to ensure that both npm and python use the same code. We also cleaned the python resources and harmonize the different code paths in the same resource.As a next step we need to use the shared package type for the python parser and harmonize the MQL resources to offer the same functionality.