Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init for aws.rds.dbcluster #5057

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add init for aws.rds.dbcluster #5057

wants to merge 2 commits into from

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Jan 1, 2025

Makes this resource work with the asset discover

cnquery> aws.rds.dbcluster{*}
aws.rds.dbcluster: {
  hostedZoneId: "1234"
  preferredBackupWindow: "08:29-08:59"
  region: "us-west-2"
  tags: {}
  id: "tim-cluster"
  createdTime: 2024-12-31 22:48:02.639 -0800 PST
  members: [
    0: aws.rds.dbinstance id="tim-cluster-instance-1" region="us-west-2" engine="aurora-postgresql" engineVersion="15.4"
  ]
  activityStreamMode: ""
  iamDatabaseAuthentication: false
  port: 5432
  availabilityZones: [
    0: "us-west-2a"
    1: "us-west-2b"
    2: "us-west-2d"
  ]
  storageAllocated: 1
  autoMinorVersionUpgrade: true
  engineLifecycleSupport: "open-source-rds-extended-support-disabled"
  storageType: null
  securityGroups: [
    0: aws.ec2.securitygroup id="sg-1234" name="default" region="us-west-2" vpc.id="vpc-ffa59787"
  ]
  storageIops: 0
  backupRetentionPeriod: 7
  latestRestorableTime: 2025-01-01 00:05:51.236 -0800 PST
  certificateAuthority: null
  storageEncrypted: true
  monitoringInterval: 60
  backupSettings: [
    0: aws.rds.backupsetting id = tim-cluster
  ]
  createdAt: 2024-12-31 22:48:02.639 -0800 PST
  multiAZ: false
  engine: "aurora-postgresql"
  status: "available"
  snapshots: []
  publiclyAccessible: null
  preferredMaintenanceWindow: "sun:11:45-sun:12:15"
  certificateExpiresAt: null
  endpoint: "tim-cluster.cluster-cvpi3ygjru5b.us-west-2.rds.amazonaws.com"
  arn: "arn:aws:rds:us-west-2:1234:cluster:tim-cluster"
  clusterDbInstanceClass: null
  engineVersion: "15.4"
  networkType: "IPV4"
  deletionProtection: false
  masterUsername: "postgres"
  activityStreamStatus: "stopped"
}

Copy link
Contributor

github-actions bot commented Jan 1, 2025

Test Results

3 209 tests  ±0   3 205 ✅ ±0   1m 42s ⏱️ -7s
  379 suites ±0       4 💤 ±0 
   29 files   ±0       0 ❌ ±0 

Results for commit b4a25d3. ± Comparison against base commit 40ab0ce.

♻️ This comment has been updated with latest results.

@@ -2080,7 +2080,7 @@ private aws.rds.backupsetting {
}

// Amazon RDS database cluster
private aws.rds.dbcluster @defaults("id region") {
private aws.rds.dbcluster @defaults("id region engine engineVersion") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we can call the resource now, we should remove private

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbinstance is still private so I kept this one private as well

tas50 added 2 commits January 24, 2025 09:33
Makes this resource work with the asset discover

Signed-off-by: Tim Smith <[email protected]>
Improves cnquery shell usage

Signed-off-by: Tim Smith <[email protected]>
@tas50 tas50 force-pushed the tas50/cluster_init branch from d1ccd19 to b4a25d3 Compare January 24, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants