🐛 add missing string.contains(dict)

Signed-off-by: Dominik Richter <[email protected]>
mondoohq · Jan 30, 2025 · ebec5d1 · ebec5d1
1 parent 5f14eec
commit ebec5d1
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/mql/mql_test.go b/mql/mql_test.go
@@ -328,5 +328,15 @@ func TestDictMethods(t *testing.T) {
 			ResultIndex: 3,
 			Expectation: true,
 		},
+		{
+			Code:        "'<< hello world >>'.contains(muser.dict.string)",
+			ResultIndex: 1,
+			Expectation: true,
+		},
+		{
+			Code:        "'<< hello + world >>'.contains(muser.dict.string)",
+			ResultIndex: 1,
+			Expectation: false,
+		},
 	})
 }
diff --git a/mqlc/builtin_simple.go b/mqlc/builtin_simple.go
@@ -99,6 +99,17 @@ func compileStringContains(c *compiler, typ types.Type, ref uint64, id string, c
 			},
 		})
 		return types.Bool, nil
+	case types.Dict:
+		c.addChunk(&llx.Chunk{
+			Call: llx.Chunk_FUNCTION,
+			Id:   "contains" + string(types.Dict),
+			Function: &llx.Function{
+				Type:    string(types.Bool),
+				Binding: ref,
+				Args:    []*llx.Primitive{val},
+			},
+		})
+		return types.Bool, nil
 	case types.Array(types.String):
 		c.addChunk(&llx.Chunk{
 			Call: llx.Chunk_FUNCTION,