fix(model): improved logging for partial models

monade · Jan 25, 2025 · f597ebd · f597ebd
1 parent d661c58
commit f597ebd
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/dist/index.cjs.js b/dist/index.cjs.js
@@ -136,12 +136,13 @@ class Parser {
     if (loadedElement.$_partial) {
       return new Proxy(instance, {
         get: function (target, prop) {
-          if (prop in target) {
-            return target[prop];
-          }
           if (prop === "$_partial") {
             return true;
           }
+          if (prop in target) {
+            debug('warn', `Trying to call property ${prop.toString()} to a model that is not included ("${loadedElement.type}"). Maybe you mean't to include it?`);
+            return target[prop];
+          }
           debug('error', `Trying to call property "${prop.toString()}" to a model that is not included. Add "${loadedElement.type}" to included models.`);
           return undefined;
         }

diff --git a/dist/index.esm.js b/dist/index.esm.js
@@ -132,12 +132,13 @@ class Parser {
     if (loadedElement.$_partial) {
       return new Proxy(instance, {
         get: function (target, prop) {
-          if (prop in target) {
-            return target[prop];
-          }
           if (prop === "$_partial") {
             return true;
           }
+          if (prop in target) {
+            debug('warn', `Trying to call property ${prop.toString()} to a model that is not included ("${loadedElement.type}"). Maybe you mean't to include it?`);
+            return target[prop];
+          }
           debug('error', `Trying to call property "${prop.toString()}" to a model that is not included. Add "${loadedElement.type}" to included models.`);
           return undefined;
         }

diff --git a/src/Parser.ts b/src/Parser.ts
@@ -91,12 +91,13 @@ export class Parser {
         instance,
         {
           get: function<T extends object>(target: T, prop: keyof T) {
-            if (prop in target) {
-              return target[prop];
-            }
             if (prop === "$_partial") {
               return true;
             }
+            if (prop in target) {
+              debug('warn', `Trying to call property ${prop.toString()} to a model that is not included ("${loadedElement.type}"). Maybe you mean't to include it?`);
+              return target[prop];
+            }
             debug('error', `Trying to call property "${prop.toString()}" to a model that is not included. Add "${loadedElement.type}" to included models.`);
             return undefined;
           },