feat(utils): countOccurrencesInArray 유틸 함수 추가 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssi02014
added
documentation
🦋 Changeset detectedLatest commit: 86bd10c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ssi02014
commented
May 23, 2024
Comment on lines
+1
to
+3
| export const isArray = <T extends readonly any[]>( | ||
| value: unknown | ||
| ): value is T => { |
There was a problem hiding this comment.
일반적인 배열 뿐만아니라 readonly 배열 까지 타입 추론을 원활하게 하기 위해 <T extends readonly any[]>로 변경하였습니다. 이를 통해 더욱 유연한 타입 지정을 할 수 있습니다! 🙏
ssi02014
commented
May 23, 2024
Comment on lines
+20
to
+23
| const readonlyTestArray = ['foo'] as const; | ||
|
|
||
| if (isArray(readonlyTestArray)) { | ||
| expectTypeOf(readonlyTestArray).toEqualTypeOf<readonly ['foo']>(); |
There was a problem hiding this comment.
기존대로라면 readonlyTestArray는 readonly ['foo'] & any[] 로 타입이 잡혀 타입 에러가 발생합니다.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 94.53% 94.59% +0.06%
==========================================
Files 74 75 +1
Lines 677 685 +8
Branches 155 157 +2
==========================================
+ Hits 640 648 +8
Misses 31 31
Partials 6 6
|
|
@Sangminnn 간단한 유틸 함수들은 리뷰어만 추가하고 머지하도록 하겠습니다! |
This was referenced May 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
issue: #157
입력한 배열에서 배열의 각 요소들이 등장한 횟수를 카운팅 해주는
countOccurrencesInArray입니다.단,
Object,Array,Set,Map과 같은 객체 타입은 카운팅에서 제외되며,null,NaN,undefined는 카운팅에 포함됩니다.PR Checklist
Contributing Guide