Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial sketch of manifest-based naming and multi A2L #76

Closed
wants to merge 2 commits into from

Conversation

pmai
Copy link
Collaborator

@pmai pmai commented Jun 18, 2024

No description provided.

@pmai pmai self-assigned this Jun 18, 2024
@pmai pmai added this to the v1.0 milestone Jun 18, 2024
@pmai pmai force-pushed the feature/multi-a2l-support branch from 32639c6 to a500a3f Compare June 18, 2024 20:34
@t-sommer
Copy link
Collaborator

t-sommer commented Jun 19, 2024

Proposal for the XML from my discussion with @pmai:

<fmiLayeredStandardManifest
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:noNamespaceSchemaLocation="../../schema/fmi3LayeredStandardXcpManifest.xsd"
    xmlns:fmi-ls="http://fmi-standard.org/fmi-ls-manifest"
    fmi-ls:fmi-ls-name="org.fmi-standard.fmi-ls-xcp"
    fmi-ls:fmi-ls-version="1.0.0-rc.4"
    fmi-ls:fmi-ls-description="Layered standard based on FMI 2.0 and FMI 3.0 for describing and implementing XCP support for FMUs, which can either provide an XCP service or allow direct memory access via A2L files.">
    
    <Interface containsXCPService="true" supportsDirectMemoryAccessViaA2L="true" definition="vECU.a2l" description="Lorem ipsum...">
        <Variable name="ENABLE_TCP" role="EnableXCPOverTCP"/>
        <Variable name="ENABLE_UDP" role="EnableXCPOverUDP"/>
    </Interface>

</fmiLayeredStandardManifest>

Actual path for binary A2L: /extras/org.fmi-standard.fmi-ls-xcp/<platform-tuple>/<definition>.

@pmai pmai force-pushed the feature/multi-a2l-support branch from a500a3f to 3960c91 Compare June 19, 2024 16:43
pmai added 2 commits June 19, 2024 18:51
Regularize naming of attributes (fixes #68, #78, #79).
Incorporate formatting changes from #69 by @t-sommer.
@pmai pmai force-pushed the feature/multi-a2l-support branch from 3960c91 to 4e4cd3e Compare June 19, 2024 16:52
@pmai
Copy link
Collaborator Author

pmai commented Jun 19, 2024

The broader refactoring can be found in #81, which can be discussed separately to this more conservative approach.

@chrbertsch
Copy link
Collaborator

Closed in favor of #81 after poll

@chrbertsch chrbertsch closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants