-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 소나클라우드 커버리지 대상 exclusions 범위 수정 #148
Conversation
Quality Gate failedFailed conditions 0.0% Coverage on New Code (required ≥ 80%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
임시로 exclude 하는 것으로 들어서 approve 했습니다~
근데 new code에 code smell 이 0개여야만 code quality Failed가 안뜨더라고요. 좀 빡센 것 같은데 해당 문서 참고해서 기준을 변경하는 것도 좋아보여요
property 'sonar.exclusions', '**/test/**, **/resources/**, **/*Application*.java, **/*Controller*.java, **/*Config.java' + | ||
'**/*Response.java, **/*Exception.java, **/security/**, **/support/**, **/Q*.java' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 추후 리팩터링하게 된다면 그때 제외하겠습니다~
권한 드렸습니다! 저희 프로젝트에서도 sonar way 말고 mocacong 규칙 만들어서 새로 기준 잡아놨었는데 mocacong에서도 코드 스멜은 측정 제외되도록 했습니다. 케이님이 보시고 더 제외하고 싶은 기준이 있다면 제외하셔도 되세요! |
개요
작업사항
주의사항