Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new exchange BitGrail #364

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

budjang
Copy link

@budjang budjang commented Jun 23, 2017

BitGrail is the only market exchange for XRB besides MERCATOX. Around 58.54% coin being traded in this place.

BitGrail is the only market exchange for XRB besides MERCATOX. Around 58.54% coin being traded in this place.
@MaciejCiemiega
Copy link
Member

@budjang Please create separate file for the exchange and do not change the MarketExample.java file. Also add changes from #365 here.

Done making the changes requested.
Add XRB virtual currency for Raiblock
Add market BitGrail
@budjang
Copy link
Author

budjang commented Aug 23, 2017

Done making the changes requested. Please check again.

@MaciejCiemiega
Copy link
Member

  1. Please do not remove files from project, like: MarketsConfig.java or MarketExample.java
  2. Put space in TTS_NAME = Bit Grail;
  3. What's with protected String parseErrorFromJsonObject(int requestId, JSONObject jsonObject, CheckerInfo checkerInfo); ?
    It doesn't look like it is going to compile, make sure it does before issuing a PR.

1. Does adding space in "String TTS_NAME = BitGrail;" is a mandatory. It seems that that's the way the market name is written.
2. Sorry about that last line. I don't from where it comes.
@budjang
Copy link
Author

budjang commented Aug 23, 2017

  1. Sorry about that. I'm a bit confused. I started creating BitGrail.java from MarketExample.java. Wrong location. What I'm planning to do is create BitGrail.java in "BitcoinChecker/dataModule/src/main/java/com/mobnetic/coinguardian/model/market/" and delete the "MarketExample.java" that I was previously modified. Is that the proper way to fix that mistake?
  2. For "MarketConfig.java", I wanted to add BitGrail as a new market. But then a text popped up saying that "this branch has a conflicts with base branch". Deleting the line that I was added didn't fix it. What is the proper way to do it?
  3. Does adding space in "String TTS_NAME = BitGrail;" is a mandatory? It seems that's the way the market name is written. Anyway I've done adding the space.
  4. Sorry about that last line in BitGrail.java. I don't know where it comes from.

@MaciejCiemiega
Copy link
Member

@budjang
regarding 3. TTS_NAME is a name that will be spoken by Text-to-speech engine and those are really two words and should be read as two, no matter how it is written in branding, logo etc. Otherwise some TTS engines may have troubles interpreting it as a single word and fail to pronounce it like we would (because we know those are two words)

@budjang
Copy link
Author

budjang commented Aug 23, 2017

Regarding the ticker, Bitgrail have https://bitgrail.com/api/v1/%$1s-%$2a/ticker, and https://bitgrail.com/api/v1/markets. Which one that should be used?

@budjang
Copy link
Author

budjang commented Aug 26, 2017

@MaciejCiemiega

What should I do next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants