Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip feature importance #91

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Conversation

egillax
Copy link
Contributor

@egillax egillax commented Jun 9, 2022

Added a flag skip_importance to skip calculating the feature importance. Solves #89 . Also added tests to confirm the flag works. Ran tests locally and they passed.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #91 (21aaad2) into main (c2e5f25) will increase coverage by 87.53%.
The diff coverage is 87.09%.

❗ Current head 21aaad2 differs from pull request most recent head e46a52e. Consider uploading reports for the commit e46a52e to get more accurate results

@@            Coverage Diff             @@
##            main      #91       +/-   ##
==========================================
+ Coverage   0.00%   87.53%   +87.53%     
==========================================
  Files         10       10               
  Lines       1054     1051        -3     
==========================================
+ Hits           0      920      +920     
+ Misses      1054      131      -923     
Impacted Files Coverage Δ
R/model.R 94.59% <84.00%> (+94.59%) ⬆️
R/pretraining.R 94.30% <100.00%> (+94.30%) ⬆️
R/sparsemax.R 65.51% <0.00%> (+65.51%) ⬆️
R/hardhat.R 88.94% <0.00%> (+88.94%) ⬆️
R/explain.R 92.30% <0.00%> (+92.30%) ⬆️
R/parsnip.R 99.08% <0.00%> (+99.08%) ⬆️
R/plot.R 100.00% <0.00%> (+100.00%) ⬆️
R/tab-network.R 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08f76d...e46a52e. Read the comment docs.

@cregouby
Copy link
Collaborator

Thanks a lot @egillax ! Would you be kind to add a line in the NEWS.md file ? (and maybe add your name in the author list in the DESCRIPTION.md if you wish)

@cregouby
Copy link
Collaborator

Great job ! Thanks @egillax

@cregouby cregouby merged commit dd451e9 into mlverse:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants