Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make feature importance calc optional when fitting tabnet #89

Closed
egillax opened this issue Mar 31, 2022 · 2 comments
Closed

Make feature importance calc optional when fitting tabnet #89

egillax opened this issue Mar 31, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@egillax
Copy link
Contributor

egillax commented Mar 31, 2022

Currently when you call tabnet::tabnet() it fits the model and then calculates feature imporances. This step can take a non trivial amount of time. When you are doing multiple fits like for hyperparameter tuning you only need the feature importances for your final model so it would be good if this step could me made optional.

@cregouby cregouby added the enhancement New feature or request label Apr 4, 2022
@cregouby
Copy link
Collaborator

cregouby commented Jun 4, 2022

Very good idea @egillax ! Would you like to propose a pull request ?

@cregouby
Copy link
Collaborator

Thanks for the P.R. hopefully it will contribute to reduce the gap in #37 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants