Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the minimum and maximum python versions #751

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

scap3yvt
Copy link
Collaborator

Fixes #N.A.

Proposed Changes

  • minimum and maximum python versions updated
  • action added to check installations

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@scap3yvt scap3yvt marked this pull request as draft November 30, 2023 21:42
Copy link
Contributor

github-actions bot commented Nov 30, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati marked this pull request as ready for review November 30, 2023 22:00
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (941532b) 94.67% compared to head (71746a2) 94.67%.
Report is 3 commits behind head on master.

❗ Current head 71746a2 differs from pull request most recent head 8f7d7a5. Consider uploading reports for the commit 8f7d7a5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #751   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files         117      117           
  Lines        8242     8242           
=======================================
  Hits         7803     7803           
  Misses        439      439           
Flag Coverage Δ
unittests 94.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarthakpati sarthakpati merged commit af5af57 into master Nov 30, 2023
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
@sarthakpati sarthakpati deleted the min-max_python-version-updated branch November 30, 2023 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants