Capture all exceptions when reading referrer details

mixpanel · Mar 9, 2020 · cb6892a · cb6892a
1 parent 1b1c005
commit cb6892a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/androidTest/java/com/mixpanel/android/mpmetrics/MixpanelInstallReferrerTest.java b/src/androidTest/java/com/mixpanel/android/mpmetrics/MixpanelInstallReferrerTest.java
@@ -6,7 +6,7 @@
 
 public class MixpanelInstallReferrerTest extends AndroidTestCase {
     public void setUp() {
-        mInstallReferrer = new InstallReferrerPlay(getContext(), "TOKEN", null);
+        mInstallReferrer = new InstallReferrerPlay(getContext(), null);
         SharedPreferences prefs = getContext().getSharedPreferences(MPConfig.REFERRER_PREFS_NAME, Context.MODE_PRIVATE);
         prefs.edit().clear().commit();
     }

diff --git a/src/main/java/com/mixpanel/android/mpmetrics/InstallReferrerPlay.java b/src/main/java/com/mixpanel/android/mpmetrics/InstallReferrerPlay.java
@@ -1,7 +1,6 @@
 package com.mixpanel.android.mpmetrics;
 
 import android.content.Context;
-import android.os.RemoteException;
 
 import com.android.installreferrer.api.InstallReferrerClient;
 import com.android.installreferrer.api.InstallReferrerStateListener;
@@ -68,15 +67,13 @@
     private static boolean sHasStartedConnection = false;
 
     private Context mContext;
-    private String mToken;
     private ReferrerCallback mCallBack;
     private InstallReferrerClient mReferrerClient;
     private int mRetryCount;
     private Timer mTimer;
 
-    public InstallReferrerPlay(Context appContext, String token, ReferrerCallback callback) {
+    public InstallReferrerPlay(Context appContext, ReferrerCallback callback) {
         this.mContext = appContext;
-        this.mToken = token;
         this.mCallBack = callback;
         this.mRetryCount = 0;
         this.mTimer= new Timer();
@@ -91,8 +88,8 @@ public void onInstallReferrerSetupFinished(int responseCode) {
                     ReferrerDetails details = mReferrerClient.getInstallReferrer();
                     String referrer = details.getInstallReferrer();
                     saveReferrerDetails(referrer);
-                } catch (RemoteException e) {
-                    MPLog.d(TAG, "There was an error fetching your referrer details.");
+                } catch (Exception e) {
+                    MPLog.d(TAG, "There was an error fetching your referrer details.", e);
                     shouldRetry = true;
                 }
                 break;

diff --git a/src/main/java/com/mixpanel/android/mpmetrics/MixpanelAPI.java b/src/main/java/com/mixpanel/android/mpmetrics/MixpanelAPI.java
@@ -447,7 +447,7 @@ public static Tweak<Byte> byteTweak(String tweakName, byte defaultValue) {
         registerMixpanelActivityLifecycleCallbacks();
 
         if (ConfigurationChecker.checkInstallReferrerConfiguration(sReferrerPrefs)) {
-            InstallReferrerPlay referrerPlay = new InstallReferrerPlay(getContext(), token, new InstallReferrerPlay.ReferrerCallback() {
+            InstallReferrerPlay referrerPlay = new InstallReferrerPlay(getContext(), new InstallReferrerPlay.ReferrerCallback() {
                 @Override
                 public void onReferrerReadSuccess() {
                     mMessages.updateEventProperties(new AnalyticsMessages.UpdateEventsPropertiesDescription(mToken, mPersistentIdentity.getReferrerProperties()));