Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: make pre-built library discoverable via CMake configuration files #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ConnorBaker
Copy link

@ConnorBaker ConnorBaker commented Jan 20, 2024

Initial work, started by @SomeoneSerge to add Mitsuba 3 to Nixpkgs: NixOS/nixpkgs#269378

This PR adds the ability to make nanothread discoverable via CMake instead of requiring projects vendor it in-tree.

Additionally, it allows testing through CMake by using CTests

CMakeLists.txt Outdated Show resolved Hide resolved
@ConnorBaker ConnorBaker marked this pull request as ready for review January 23, 2024 04:06
@ConnorBaker
Copy link
Author

I force-pushed to update the PR and take care of the extra $CMAKE_CURRENT_SOURCE_DIR I introduced -- thank you for the feedback!

@ConnorBaker ConnorBaker requested a review from wjakob January 23, 2024 04:06
Copy link
Member

@wjakob wjakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more questions/followups (sorry, I'm not so familiar with the CMake install workflow)

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@ConnorBaker ConnorBaker force-pushed the feat/reusable-cmake branch 2 times, most recently from e62ba9a to a9535a7 Compare January 31, 2024 05:16
@ConnorBaker
Copy link
Author

After reading through the CMake docs, I've switched to use CMAKE_INSTALL_* where appropriate -- these should be relative paths, as each has a CMAKE_INSTALL_FULL_* counterpart which is the absolute path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants