6393 add product chooser to system chooser screen #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkachel
requested changes
Jan 14, 2025
src/app/page.tsx
Outdated
| <p>Loading systems...</p> | ||
| )} | ||
| </SelectSystemContainer> | ||
| <> |
There was a problem hiding this comment.
This doesn't need to be wrapped, it can just be the SelectSystemContainer component.
src/app/page.tsx
Outdated
| import { styled } from "@mitodl/smoot-design"; | ||
| import { Typography } from "@mui/material"; | ||
| import { Typography, Button } from "@mui/material"; |
There was a problem hiding this comment.
We have a Button in smoot-design - this should use that so it matches the visual style of the rest of the app(s). (The props are pretty much the same between the two, I think, so this should be just swapping the imports. You can also pull in styled from smoot-design if you want to apply custom CSS to it too. See https://github.com/mitodl/unified-ecommerce-frontend/blob/main/src/page-components/CartSummary/CartSummary.tsx to see in action.)
cp-at-mit
deleted the
6393-add-product-chooser-to-system-chooser-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/6393
Description (What does it do?)
Adds the ability to adds products from a the selected system to the cart.
How can this be tested?