-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: force all enrollments #1761
Conversation
On the testing part:
|
As per our discussion, unenrollment looks fine now. Maybe it was some issue with the API keys. Could you please test this PR again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was facing issues with unenrollment but after adding the right value for EDX_API_KEY
I was able to test all the cases mentioned in the PR description. So this looks good. 👍
adfe800
to
59b045c
Compare
This seems ok to merge to me. When we change the setting in open edX to invite only, we'll need to test carefully & also monitor the logs for any errors. |
What are the relevant tickets?
Fixes https://github.com/mitodl/hq/issues/1773
Description (What does it do?)
We are going to mark courses as invite-only in edX to stop direct enrollments in edX. It will require us to force the course enrollments to bypass invitation checks. This PR forces all the course enrollments.
Screenshots (if appropriate):
How can this be tested?
COURSES_INVITE_ONLY
in edX.Additional Context