Add frontend for the http (not websocket) chat endpoint #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-131
to
+130
| await self.send_event(event=chunk, more_body=True) | ||
| await self.send_chunk(chunk) |
There was a problem hiding this comment.
Locally, this iteration takes many seconds, but the body text doesn't seem to actually be sent until it finishes. It is sent incrementally if an artificial await asyncio.sleep(0.1) is inserted.
So, something doesn't seem right here, but it behaves this way on main, too, so not related to the change from SSE to regular text.
ChristopherChudzicki
force-pushed
the
cc/fe
branch
from
bb43bf6 to
7c49eb0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.github/workflows/ci.yml
Outdated
Comment on lines
82
to
117
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: ./frontend-demo | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||
| - uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4 | ||
| with: | ||
| node-version: "^22" | ||
| cache: yarn | ||
| cache-dependency-path: yarn.lock | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --immutable | ||
|
|
||
| - name: Format | ||
| run: yarn run fmt-check | ||
|
|
||
| - name: Lints | ||
| run: yarn run lint-check | ||
|
|
||
| # do build before typecheck. See https://github.com/vercel/next.js/issues/53959#issuecomment-1735563224 | ||
| - name: Build | ||
| run: yarn build | ||
| env: | ||
| NODE_ENV: production | ||
| NEXT_PUBLIC_MITOL_API_BASE_URL: "http://ai.test.local:8003" | ||
|
|
||
| - name: Typecheck | ||
| run: yarn typecheck | ||
|
|
||
| - name: Tests | ||
| run: yarn test | ||
| env: | ||
| CODECOV: true | ||
| NODE_ENV: test |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions
.github/workflows/ci.yml
Outdated
Comment on lines
88
to
94
| - uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4 | ||
| with: | ||
| node-version: "^22" | ||
| cache: yarn | ||
| cache-dependency-path: yarn.lock | ||
|
|
||
| - name: Install dependencies |
Check notice
Code scanning / CodeQL
Unversioned Immutable Action
ChristopherChudzicki
force-pushed
the
cc/fe
branch
from
25e39b5 to
df7d3a9
Compare
ChristopherChudzicki
changed the title
| FROM ghcr.io/berriai/litellm:main-latest | ||
| FROM ghcr.io/berriai/litellm:main-stable |
There was a problem hiding this comment.
main-latest was giving an error, moving to stable fixed it.
Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime
create failed: runc create failed: unable to start container process: exec: "docker/prod_entrypoint.sh": stat
docker/prod_entrypoint.sh: no such file or directory: unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Description (What does it do?)
Adds a very minimal frontend intended for local development and possibly demoing that hits the chat API with component from https://mitodl.github.io/smoot-design/?path=/docs/smoot-design-aichat--docs
Additionally, this changes the SSE (server-sent events) endpoint to use raw text streaming. SSE proved somewhat inconvenient—. Browsers have an interface EventStream to parse the responses, but it only works with GET requests not POST. If we need a more structured format in the future, the format described here https://sdk.vercel.ai/docs/ai-sdk-ui/stream-protocol#data-stream-protocol might be good.
How can this be tested?
With the repo set up (you should only need
OPENAI_API_KEY),docker compose upand