Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ts; remove suppressImplicitAnyIndexErrors #68

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

ChristopherChudzicki
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki commented Feb 16, 2024

What are the relevant tickets?

An update on the way to #65

Description (What does it do?)

This PR updates Typescript and removes suppressImplicitAnyIndexErrors. The suppressImplicitAnyIndexErrors setting is deprecated and will be removed in TS 5.5, which probably isn't too far away. (5.3 is current).

Removing suppressImplicitAnyIndexErrors raised 9 errors that I suppressed with some typecasting.

How can this be tested?

Tests should pass.

It should be very clear from the changes that there are no functional changes in the source code. (Though it is possible the compiled code has changed due to TS update.) You can test the functionallity using mitodl/ocw-hugo-themes#1313 modified via

yarn remove @mitodl/course-search-utils
yarn add @mitodl/course-search-utils@https://github.com/mitodl/course-search-utils.git#c99bef7105cb4dc67503b39c29c6cc7ac0613a16
yarn start www

and check the search page.

node-version: 15.3.0
node-version: 20.11.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated linting packages were throwing errors with old node version; Node 15 is long unsupported, anyway.

Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChristopherChudzicki ChristopherChudzicki merged commit 4d45f3c into main Feb 16, 2024
2 checks passed
@odlbot odlbot mentioned this pull request Mar 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants