Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct selection behavior for nodes and connections #189

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Correct selection behavior for nodes and connections #189

merged 3 commits into from
Jan 8, 2025

Conversation

miroiu
Copy link
Owner

@miroiu miroiu commented Jan 4, 2025 •
edited
Loading

📝 Description of the Change

This fix ensures that selecting a node will deselect all connections and vice versa when the SelectionType is Replace, which allows multi-selection as expected.

TODO:

  • Fix CancelSelecting not re-selecting unselected connections
  • BeginSelecting should only unselect all connections if SelectionType is Replace

Fixes #188

🐛 Possible Drawbacks

@miroiu miroiu merged commit 13f75c2 into master Jan 8, 2025
4 checks passed
@miroiu miroiu deleted the fix/selection-behavior branch January 8, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Selection of nodes and connections combined
1 participant
@miroiu