Misc improvements in node gui. #1869
Open
+589
−300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When the network type is passed from the command line, the app will actually use it, without asking the user. * Some `expect`s were replaced by errors to avoid crashes. * Logging is now initialized in the cold mode too (only the console logging is enabled). The app will also print a warning to the log when the log-to-file or clean-data options are specified in the cold mode. * The message "Data directory is now clean ... Please restart the node" is no longer shown as an error. * The log-to-file option was moved from RunOptions to the top-level options.
ImplOfAnImpl
requested review from
erubboli,
azarovh and
OBorce
as code owners
azarovh
approved these changes
Jan 22, 2025
OBorce
force-pushed
the
refactor/upgrade-iced-version
branch
from
3c6c9da to
eff8579
Compare
OBorce
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of minor improvements in node-gui:
expects were replaced with errors to avoid crashes, e.g. when a second node is started with a separate data directory but the same p2p listening port.I also tried improving the error messages a bit, though they're still not very specific (e.g. if the port is busy, it'll say "Error subscribing to P2P events: Callee subsystem did not respond").
RunOptionsto the top-level options, as we discussed. (The clean-data option is still inRunOptions)MintlayerNodeGUIa bit and renamed it to GuiState.