APS-1857 Copied cas1 timeline api types to cas1 schema. #2902
Conversation
|
Can you please add something into the commit message explaining what this commit is doing? |
...lin/uk/gov/justice/digital/hmpps/approvedpremisesapi/controller/cas1/Cas1PeopleController.kt
Outdated
Show resolved
Hide resolved
It's there. may be some line break hides those. |
Apologies, i'm being a dummy and misread the github UI :) |
|
A minor point and don't worry about addressing on this PR. We tend to prefix our branch names with either |
vbala-moj
force-pushed
the
APS-1857-copy-timeline-api-types-to-cas1
branch
2 times, most recently
from
2f73f74 to
d279d01
Compare
| ), | ||
| APPROVED_PREMISES_BOOKING_MADE( | ||
| DomainEventCas.CAS1, | ||
| Cas1EventType.bookingMade.value, | ||
| "An Approved Premises booking has been made", | ||
| TimelineEventType.approvedPremisesBookingMade, | ||
| Cas1TimelineEventType.bookingNotMade, |
There was a problem hiding this comment.
i think this should be bookingMade?
| ), | ||
| APPROVED_PREMISES_PLACEMENT_APPLICATION_ALLOCATED( | ||
| DomainEventCas.CAS1, | ||
| Cas1EventType.placementApplicationAllocated.value, | ||
| "An Approved Premises Request for Placement has been allocated", | ||
| TimelineEventType.approvedPremisesPlacementApplicationAllocated, | ||
| Cas1TimelineEventType.assessmentAllocated, |
There was a problem hiding this comment.
i think this should be placementApplicationAllocated?
| @@ -42,4 +43,22 @@ enum class ApprovedPremisesApplicationStatus(val apiValue: ApiApprovedPremisesAp | |||
| fun valueOf(apiValue: ApiApprovedPremisesApplicationStatus): ApprovedPremisesApplicationStatus = | |||
| ApprovedPremisesApplicationStatus.entries.first { it.apiValue == apiValue } | |||
| } | |||
|
|
|||
| fun toCas1Status(): Cas1ApplicationStatus { | |||
| return when (this) { | |||
There was a problem hiding this comment.
i like using the when here, it makes sure we've covered all mappings 👍
| createdBy: | ||
| $ref: '_shared.yml#/components/schemas/User' | ||
| payload: | ||
| $ref: '_shared.yml#/components/schemas/TimelineEventContentPayload' |
There was a problem hiding this comment.
i guess this should be copied into the CAS1 schemas too?
to be honest we could probably remove it from the shared.yml (and shared API) completely because the UI won't be using it yet. Hopefully that makes it easier?
| @@ -1004,3 +1004,129 @@ components: | |||
| - updatedReferenceNumber | |||
| - updatedReason | |||
| - updatedNotes | |||
| Cas1TimelineEvent: | |||
There was a problem hiding this comment.
i think we can make a few fields mandatory (i appreciate they weren't before)
- type
- id
- occurredAt
| - booking | ||
| - assessment | ||
| - assessmentAppeal | ||
| - cas1SpaceBooking |
There was a problem hiding this comment.
this can just be spaceBooking in this context
vbala-moj
force-pushed
the
APS-1857-copy-timeline-api-types-to-cas1
branch
2 times, most recently
from
ebd633b to
bcc0aff
Compare
Refactored services and transformers to return cas1 api types.
vbala-moj
force-pushed
the
APS-1857-copy-timeline-api-types-to-cas1
branch
from
bcc0aff to
6e98f66
Compare
https://dsdmoj.atlassian.net/browse/APS-1857