Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename metadata flag to add-metadata for put operations #356

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

chenrui333
Copy link
Contributor

after #349, seeing list flag redefined: metadata issue, thus renaming the flag name to extended-metadata.

relates to Homebrew/homebrew-core#203322

@klauspost
Copy link
Collaborator

Second regression from #349 :/

I am more a proponent of renaming the field in #349 to add-metadata and keeping this.

Would you like to do that change, otherwise just let me know, and I'll send a PR?

@chenrui333
Copy link
Contributor Author

yeah, works for me, one sec.

@chenrui333
Copy link
Contributor Author

@klauspost done. thanks!

@chenrui333 chenrui333 changed the title fix: rename metadata flag to extended-metadata for list command fix: rename metadata flag to add-metadata for put operations Jan 6, 2025
@klauspost
Copy link
Collaborator

Thanks a bunch! LGTM

@harshavardhana harshavardhana merged commit 86b8fc8 into minio:master Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants