Fix Addresses Used in IamAwsProvider

[sam-mosleh]

Fixes #1459

[sam-mosleh]

@balamurugana Since Python 3.7+ includes a built-in _replace method which is the preferred way to alter the SplitResult values, would you be open to refactoring the code to remove the custom url_replace function?

If you're on board with this, I can submit a follow-up PR to make the change.

[balamurugana]

@balamurugana Since Python 3.7+ includes a built-in _replace method which is the preferred way to alter the SplitResult values, would you be open to refactoring the code to remove the custom url_replace function?

If you're on board with this, I can submit a follow-up PR to make the change.

@sam-mosleh You could leave the code as is.

[setu4993]

I just noticed this. I just created #1464 which is an alternative implementation for the same fix.

[setu4993]

I don't have a preference on which one we move forward with but would love to see either be merged + released soon.

[sam-mosleh]

@setu4993 Your implementation of the fix exactly matches the initial implementation in this PR. However, there were changes requested earlier. Thanks for the ping!

@balamurugana Is there anything blocking the merge? It’s been almost two weeks without feedback, and I’d appreciate any updates on this.

[balamurugana]

I am closing on behalf of #1465