Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move non-private static error to the access modifier (when there is one) #2425

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Move non-private static error to the access modifier (when there is one) #2425

wants to merge 2 commits into from
+8 −1

Conversation

O7410
Copy link
Contributor

@O7410 O7410 commented Jan 8, 2025

before: entire line highlighted in red:
image
after: only the keyword (when there is one) is highlighted:
image

Earthcomputer
Earthcomputer requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@Earthcomputer Earthcomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if accessModifier already does this, but in case it doesn't, you should make sure it always lands on the access modifier and not on other modifiers such as static.

src/main/kotlin/platform/mixin/inspection/StaticMemberInspection.kt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Earthcomputer Earthcomputer Earthcomputer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@O7410 @Earthcomputer