-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADA-SVR (2/4) add comments and documentation of the functions and test #73
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 81.70% 81.72% +0.02%
==========================================
Files 43 43
Lines 2312 2315 +3
==========================================
+ Hits 1889 1892 +3
Misses 423 423 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good but we should think of codebase organization.
Moreover ada_svr
is too cryptic to be a good module name.
hidimstat/ada_svr.py
Outdated
@@ -0,0 +1,51 @@ | |||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd rather not have ada_svr as a module directly under hidimstat. Should be in something like hidimstat.estimators
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine for me.
Do you prefer call this module: procedures or methods or models ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe models.
But we should first discuss the organization of the whole thing to make a good decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the issue #86
I added a function for computing the pvalue from the output of ada_svr. |
Avoid to modify X in the function by the line 37. Create new variable to compensate it.
__all__ allow to avoid to import all function when there is an import with *.
… into PR_comment_ADA-SVR
I add a definition of all . This is from the advice of this section. |
update bilbilography Co-authored-by: Joseph Paillard <[email protected]>
This pull request is the next step after #58 .
This is an example of a template of documentation for functions.