Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADA-SVR (3/4) PR example of models #100
base: main
Are you sure you want to change the base?
ADA-SVR (3/4) PR example of models #100
Changes from 19 commits
35a877f
45d9992
e28b8b8
0a2fab4
02adbb5
358bd68
fd41d6c
df80078
2a8f3c4
d3871f4
f868469
b1c14e1
7cf0c4d
71d407e
a530252
7ab4bfb
83f049e
5887b1b
05f47a7
e607676
2e4037a
ca9575e
5c42cc3
d73aeb9
ded4d51
ebad58c
64116e9
16cdad6
d41554f
e895962
6e2d4c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 4 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L1-L4
Check warning on line 7 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L7
Check warning on line 20 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L20
Check warning on line 31 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L24-L31
Check warning on line 40 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L33-L40
Check warning on line 45 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L42-L45
Check warning on line 48 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L47-L48
Check warning on line 51 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L51
Check warning on line 63 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L63
Check warning on line 67 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L65-L67
Check warning on line 72 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L69-L72
Check warning on line 76 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L76
Check warning on line 79 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better:
plot_p_values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None
Check warning on line 102 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L102
Check warning on line 107 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L104-L107
Check warning on line 114 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L114
Check warning on line 116 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L116
Check warning on line 121 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L121
Check warning on line 125 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L124-L125
Check warning on line 128 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L128
Check warning on line 130 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L130
Check warning on line 135 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L135
Check warning on line 140 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L139-L140
Check warning on line 147 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L147
Check warning on line 149 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L149
Check warning on line 152 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L152
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite get the difference between the two functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first function plot_pvalue_H0 plots just the pvalue and the corrected pvalue with imshow.
The second function plot_pvalue_H1 plots just the 1-pvalue and the 1-corrected pvalue with imshow.
I want it to separate the t-test to be an important variable and not to be an important variable.
It's actually just a basic plot but this needs to be improved for mixing with the score (beta_hat). It should be replaced by a plot with the score of each variable and the associate p-value for being an important variable or not.
Check warning on line 179 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L175-L179
Check warning on line 187 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L186-L187
Check warning on line 194 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L194
Check warning on line 198 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L197-L198
Check warning on line 202 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L201-L202
Check warning on line 210 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L210
Check warning on line 215 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L214-L215
Check warning on line 223 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L222-L223
Check warning on line 226 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L226
Check warning on line 238 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L237-L238
Check warning on line 240 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L240
Check warning on line 246 in examples/_utils/plot_dataset.py
Codecov / codecov/patch
examples/_utils/plot_dataset.py#L244-L246