-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make milvus-lite a optional dependency #2603
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SuperSecureHuman The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @SuperSecureHuman! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
Signed-off-by: SuperSecureHuman <[email protected]>
8f711c9
to
9d2670a
Compare
@SuperSecureHuman Usually a system can run Milvus cluster or Milvus standalone is able to host ~200MB of PyMilvus, cuz 200MB is nothing comparing to Milvus. Also, if resources are limited, Milvus-lite is the best choice. So why are you using Milvus but concerning PyMilvus disk usage? Also mounting volumes might be a solution to use milvus-lite inside a docker. |
It's when using pymilvus connect to an existing cluster.. The node does not run milvus, rather connects to milvus. Edit: This will help to speedup image builds, and reduce image sizes, helping with deployment times (especially when the application is on autoscaling) |
@SuperSecureHuman Hi, THX for the reply. We want milvus-lite to be part of PyMilvus by default so I labelled this PR
OR, a even simpler choice:
|
BTW you could try this in your Dockerfile: |
Hi, So the current workaround that I am doing is, installing pymilvus without deps, and installing the needed deps manually.. In our case, this alone gives us the required result (and ~20% reduction in image size) You may close the issue if needed, this can be a suggested way if someone wants to setup their minimal docker images. |
Thanks for the contribution anyway! |
Right now, milvus lite is a required dependency. When trying to use it under docker, milvus-lite alone uses ~150MB.
This space is mostly unwanted if we dont use local DB (using localdb is unlikely in docker deployments)