Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5 release schedule #160

Open
andrejleitner opened this issue Mar 16, 2022 · 14 comments · May be fixed by #231
Open

Version 5 release schedule #160

andrejleitner opened this issue Mar 16, 2022 · 14 comments · May be fixed by #231

Comments

@andrejleitner
Copy link

Is there a plan to release version 5 in the foreseeable future?

@luin
Copy link

luin commented Mar 29, 2022

Sorry if this is off-topic, ioredis has just released v5.0.0. I think it would be nice if this update could be added to v5 😄.

@ehaynes99
Copy link

Will the current version work with ioredis 5? The type definitions don't quite match, but they're not actually correct anyhow.
They define it as:

interface CompatibleRedisClient {
    eval(args: EvalArg[], callback?: (err: Error | null, res: any) => void): any;
}

Whereas in the 4.2 codebase, the only function called on the client is evalsha

@wolfido92
Copy link

We want to upgrade to ioredis v5, will you update in the near future?
We can help with the migration if you need anything.

@anton-brass
Copy link

Is there any update here? We have a library conflict with typeorm, which uses a newer version of io-redis, and we need to update to that.

@palumbamboo
Copy link

Hello guys, any news for the v5 release? Thanks

@Nikamura
Copy link

I have opened PR to potentially get this done.
#231

@ChrisZieba
Copy link

@mike-marcacci Are you open to adding any maintainers of this project?

@mike-marcacci
Copy link
Owner

Hi @ChrisZieba, I would actually be very interested in that. This project continues to work well in the places where I have it deployed, and other responsibilities have prevented me from giving it much time that isn't directly related to those use-cases. There are some finer points about redlock that I'd need a maintainer to understand – a fair number of requests have come in around use patterns that are outside the scope of this tool and would be unsound, so I wouldn't want to make changes that encourage these.

I've avoided publishing a final v5 for far too long now... I think incorporating the miscellaneous fixes and improvements (and exploring a couple reported bugs) are long overdue, but this is a can I've obviously been kicking for far too long now.

Is this something you'd be interested in, or know someone who would be capable and willing to take that on?

@mze9412
Copy link

mze9412 commented Jun 7, 2023

Any news on this? :/

@slavafomin
Copy link

slavafomin commented Aug 3, 2023

The weirdest thing is that the latest dist tag on npm points to the 5.0.0-beta.2 version (which is not even in the "releases" section on GitHub), while it should point only to a stable version, which should be 4.2.0 I guess.

Does it mean that the 5.0.0-beta.2 is actually stable? Is it safe to use it in production? Or is this just a publishing mistake?

@develth
Copy link

develth commented Oct 13, 2023

Release of 5.0.0-beta.2 was in March 2022. If it was an mistake, there was plenty of time to correct it.
IMHO the Project looks like it´s dead.

@djMax
Copy link

djMax commented Oct 30, 2023

I've rewritten this in more modern infra - ioredis5, TS, and vitest. Published as @sesamecare-oss/redlock. Happy to try and make a PR if it would be welcome.

https://github.com/sesamecare/redlock

@yharaskrik
Copy link

I've rewritten this in more modern infra - ioredis5, TS, and vitest. Published as @sesamecare-oss/redlock. Happy to try and make a PR if it would be welcome.

https://github.com/sesamecare/redlock

I heavily support this idea!

You could just open the PR regardless, then at least the community members in this thread could look and provide some feedback.

@capaj
Copy link

capaj commented Aug 7, 2024

@djMax awesome work, someone should open a PR to deprecate this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.